Adding item to list using constructor C#

Question

I am learning C# and was trying different ways to add to list. I tried two different method below . First One does not work, second one does work.

What is wrong with first method?

 class Program
    {
        static void Main(string[] args)
        {
            Employee emps = new Employee();
            emps.PromoteEmp(emps.emp);
        }
    }

    class Employee
    {
        public int ID { get; set; }
        public string Name { get; set; }
        public int Salary { get; set; }
        public int Experience { get; set; }
        public List<Employee> emp;

        public Employee()
        {
            emp = new List<Employee>();
            emp.Add(new Employee() { ID = 1, Name = "A", Experience = 6, Salary = 30000 });
            emp.Add(new Employee() { ID = 2, Name = "B", Experience = 4, Salary = 10000 });
            emp.Add(new Employee() { ID = 1, Name = "C", Experience = 5, Salary = 15000 });
            emp.Add(new Employee() { ID = 1, Name = "D", Experience = 8, Salary = 60000 });
        }

        public void PromoteEmp(List<Employee> empList)
        {
            foreach (Employee item in empList)
            {
                if (item.Experience > 5)
                {
                    Console.WriteLine(item.Name + " promoted ");
                }
            }
        }
    }

Second Method

 class Program
    {
        static void Main(string[] args)
        {
            Employee emps = new Employee();
            emps.AddToList();
            emps.PromoteEmp(emps.emp);
        }
    }

    class Employee
    {
        public int ID { get; set; }
        public string Name { get; set; }
        public int Salary { get; set; }
        public int Experience { get; set; }
        public List<Employee> emp;


        public void AddToList()
        {
          emp = new List<Employee>();
          emp.Add(new Employee() { ID = 1, Name = "A", Experience = 6, Salary = 30000 });
          emp.Add(new Employee() { ID = 2, Name = "B", Experience = 4, Salary = 10000 });
         emp.Add(new Employee() { ID = 1, Name = "C", Experience = 5, Salary = 15000 });
         emp.Add(new Employee() { ID = 1, Name = "D", Experience = 8, Salary = 60000 });
        }

        public void PromoteEmp(List<Employee> empList)
        {
            foreach (Employee item in empList)
            {
                if (item.Experience > 5)
                {
                    Console.WriteLine(item.Name + " promoted ");
                }
            }
        }
    }

Thank You :)

Both look good to me... Did you use the debugger? Any messages? — DrKoch
– DrKoch, Commented Feb 10, 2015 at 6:13
@mybirthname Just started learning C# and new to visual studio too :) Will take your suggestion :) — Richa
– Richa, Commented Feb 10, 2015 at 6:18

Blindy · Accepted Answer · 2015-02-10 06:14:44Z

1

It's easy, in the first case you construct your Employee which constructs more Employees and so on and so forth.

In fact if you bothered to paste the exception you got, it would be readily obvious: StackOverflowException.

answered Feb 10, 2015 at 6:14

Blindy

68k10 gold badges96 silver badges141 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Richa Over a year ago

Yes that is what the exception i am getting. What is get around for it? Thanks :)

Blindy Over a year ago

Delete all you wrote, it makes no sense for an employee to hold a list of employees. Think about what you mean to model, write it on a whiteboard if you need to, and start over.

Richa Over a year ago

So the second method is fine?? I can do it that way right?

DrKoch Over a year ago

No. Keep class employee and "List of emplyees" separate! An employee should not contain a list of all employees, that is bad design. In a later stage you may have a "chief" with people which report to him, but that's a different story...

Richa Over a year ago

@DrKoch so should i create employee list in different class?? Like in main method??

Manish Parakhiya · Accepted Answer · 2015-02-10 06:13:55Z

0

Your first code cause infinite looping as you are adding same class Employee in Constructor.

answered Feb 10, 2015 at 6:13

Manish Parakhiya

3,8083 gold badges24 silver badges26 bronze badges

Comments

Naresh Parmar · Accepted Answer · 2015-02-10 06:26:31Z

0

Actually, program goes to infinite loop in constructor and never complete.

In Main():

from this line : Employee emps = new Employee();

program goes to constructor to initialize object.

Now in constructor:

emp.Add(new Employee() { ID = 1, Name = "A", Experience = 6, Salary = 30000 });

At this line, you are adding new Employee object to list. Here object initialization again, and thus program goes to infinite loop in constructor.

Your program will never reach at final line.

answered Feb 10, 2015 at 6:26

Naresh Parmar

4623 silver badges16 bronze badges

Collectives™ on Stack Overflow

Adding item to list using constructor C#

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related