String exception due to array index

Question

I have a loop that initiates an array of strings then cuts them to give the desired information:

for (Element referenceId: referenceIds){
    ref[i] = referenceId.attr("href");
    String[] str = new String[24]; 
    str[i] = ref[i].substring(ref[i].lastIndexOf("listing-") + 8, ref[i].indexOf(".htm"));
    System.out.println(str[i]); 
    i++;
}

However I'm getting an error crashing the program:

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 24
    at Jobs.main(Jobs.java:30)

What is this and how do I fix it? I've tried changing the array size to less but that didn't work.

Ravi K Thapliyal · Accepted Answer · 2015-02-12 06:47:40Z

1

Change this

String[] str = new String[24];

to this

String[] str = new String[ref.length];

Your ref array is probably having 25 or more items. So, as soon as the loop iterates over the 25th element (i.e. with index 24) you get an ArrayIndexOutOfBoundsException: 24.

answered Feb 12, 2015 at 6:47

Ravi K Thapliyal

51.9k9 gold badges80 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ravi K Thapliyal Over a year ago

It would help if you post the whole method code that covers the ref array.

pbo · Accepted Answer · 2015-02-12 12:14:23Z

1

You are iterating over referenceIds so you should use the size of this array/list for maybe it will change:

String[] str = new String[referenceIds.lenght];

You might also want to declare the String[] str outside the for loop.

Chears!

edited Feb 12, 2015 at 12:14

answered Feb 12, 2015 at 6:52

pbo

216 bronze badges

Collectives™ on Stack Overflow

String exception due to array index

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related