Using a parameter with a Javascript object?

Question

Currently I can do:

function addStat() {
player.str = player.str + 1;
}

But I want to be able to use things other than just "str" with my player object. So I decided with doing something like this:

function addStat(stat) {
player.stat = player.stat + 1;
}

But that doesn't seem to work, iv'e tried looking up the syntax for using parameters but could not find anything similar to the way I need.

I learned about "this" but I can't get it to work with my function.

I thought this:

function addStat(thing, stat) {
thing.stat = thing.stat + 1;
statReset();
}

would work but I can see why it won't. I made sure the rest of my javascript and html work and when I add those functions nothing breaks, it just doesn't work.

possible duplicate of Dynamically access object property using variable — Jamiec
– Jamiec, Commented Feb 12, 2015 at 16:06

ndugger · Accepted Answer · 2015-09-28 18:14:34Z

4

When assigning properties with a variable, you need to use bracket notation, as opposed to dot notation. This, then, looks like:

function addStat(stat) {
    (stat in player) ? ++player[stat] : player[stat] = 1;
}

Due to comments (that I disagree with), I figured I should mention that since you are attempting to modify a property that may not exist, you should also add a safety check to see if you can modify it.

Otherwise you will be modifying undefined, and that will cause undesired output..

edited Sep 28, 2015 at 18:14

answered Feb 12, 2015 at 16:05

ndugger

7,5715 gold badges35 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

ndugger Over a year ago

@Andy -- while your comment is valid, it has nothing to do with the current question at hand.

Alnitak Over a year ago

@Jamiec it works for setting new properties, it doesn't work for modifying properties that don't yet exist.

Jamiec Over a year ago

@Alnitak - How can you modify something that doesnt exist?

Andy Over a year ago

@NickDugger, I disagree. The OP is moving from using specific keys to possibly passing in a parameter for a key that doesn't yet exist. I think that's worth mentioning.

Andy Over a year ago

@NickDugger, if you disagree with it you shouldn't add it to your answer. That's just weird, man.

|

LS_ᴅᴇᴠ · Accepted Answer · 2015-02-12 16:06:42Z

0

You can access properties with []:

function addStat(prop) {
    player[prop] = player[prop] + 1;
}

so calling addStat("stat") will actually set player.stat.

answered Feb 12, 2015 at 16:06

LS_ᴅᴇᴠ

11.2k1 gold badge27 silver badges46 bronze badges

3 Comments

Andy Over a year ago

No, it will add 1 to player.stat on the assumption that the key exists.

LS_ᴅᴇᴠ Over a year ago

OP post also assumes this. There is no checking in original code.

Andy Over a year ago

The OP doesn't assume this because he might decide to pass in a parameter for a keys that doesn't exist yet. I think that's worth mentioning.

CupawnTae · Accepted Answer · 2015-02-12 16:15:14Z

0

In javascript, the syntax

object.key

is equivalent to

object["key"]

So your thing.stat is equivalent to thing["stat"], i.e. the key is the literal string "stat" when what you really want is to use the value referenced by the parameter stat as the key:

thing[stat] = thing[stat] + 1;

answered Feb 12, 2015 at 16:15

CupawnTae

14.7k3 gold badges31 silver badges62 bronze badges

Collectives™ on Stack Overflow

Using a parameter with a Javascript object?

3 Answers 3

10 Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

10 Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related