Getting random number with each button click

Question

I'm trying to get a random number each time someone clicks a button. The range of the numbers is from one(1) to five(5). If this question has already been asked and answered, please point me to the question and I'll delete this one to avoid duplication.

HTML

<div id="content"></div>
<button id="add">Add Object</button>

JS

$(document).ready(function(){
    var Player = {
        name: "One",
        weapon: Sword = {
            damage: 1 + Math.floor(Math.random() * 5),
            speed: 10
        }
    }
    var player_damage = Player.weapon.damage;

    $("#add").on("click", function(){
        $("#content").append(player_damage + " ");
    })
})

Fiddle

You only generated the number once. Everytime you click the button, you have the number generated that only time (always the same). — Hugo Sousa
– Hugo Sousa, Commented Feb 13, 2015 at 19:25

Jeremy Thille · Accepted Answer · 2015-02-13 19:27:40Z

4

You don't update your number on click. You set it only once.

var Player = {
  name: "One",
  weapon: Sword = {
    damage: 0,
    speed: 10
  }
}

$("#add").on("click", function(){
  Player.weapon.damage = 1 + Math.floor(Math.random() * 5);
  $("#content").append(Player.weapon.damage + " ");
})

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<div id="content"></div>
		<button id="add">Add Object</button>

answered Feb 13, 2015 at 19:27

Jeremy Thille

26.4k12 gold badges48 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Jeremy Thille Over a year ago

You're welcome - Please validate the answer if you're happy with it :)

user3542456 Over a year ago

I'm accepting it, when it lets me in about 4 minutes

Jeremy Thille Over a year ago

These were the longest 4 minutes of my life :p

user3542456 Over a year ago

Haha, sorry, I got side tracked and honestly forgot about it.

MarkG · Accepted Answer · 2015-02-13 19:27:43Z

2

Generate the new number inside the click function:

 $("#add").on("click", function(){
            var damage= 1 + Math.floor(Math.random() * 5);
            $("#content").append(damage.toString() + " ");
        })

jsfiddle

answered Feb 13, 2015 at 19:27

MarkG

6474 silver badges10 bronze badges

Comments

Samuel Goodell · Accepted Answer · 2015-02-13 19:28:48Z

0

I updated it using a JavaScript property on the Sword object. Whenever the damage property is accessed, it generates a new value using a getter:

http://jsfiddle.net/hd7tec5f/3/

Object.defineProperty(Sword, "damage", {
    get: function() {
        return 1 + Math.round(Math.random() * 1));
    }
});

answered Feb 13, 2015 at 19:28

Samuel Goodell

6403 silver badges10 bronze badges

Comments

manzapanza · Accepted Answer · 2015-02-13 19:30:35Z

0

$(document).ready(function(){
   $("#add").on("click", function(){
        var Player = {
            name: "One",
            weapon: Sword = {
                damage: 1 + Math.floor(Math.random() * 5),
                speed: 10
            }
        };

        var player_damage = Player.weapon.damage;                                           
        $("#content").append(player_damage + " ");
    })
});

http://jsfiddle.net/manzapanza/rayn6m4L/

answered Feb 13, 2015 at 19:30

manzapanza

6,2914 gold badges43 silver badges51 bronze badges

3 Comments

PM 77-1 Over a year ago

I believe recreating an object again and again unless absolutely necessary is a bad design.

user3542456 Over a year ago

This is creating the object each time I click the button, not something I want to do as it will eventually cause huge memory and performance issues.

manzapanza Over a year ago

I agree with you, my answer could be improved. Personally I prefer much more the solution of the accepted answer

Collectives™ on Stack Overflow

Getting random number with each button click

4 Answers 4

4 Comments

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related