Regex not replacing text in JS

Question

I have the specific code :

<script>

$.fn.revert = function(){
return this.each(function() {
var txt = $(this).html().replace(/<span class="gradientizer-done" style='color:rgb\(\d{1,3},\d{1,3},\d{1,3}\)>.<\/span>/g,'');
$(this).html(txt);
});
};

</script>

And this code :

<p class="grad2" one="ffffff" second="000000">
<span class="gradientizer-done" style="color:rgb(255,255,255)"> </span>
<span class="gradientizer-done" style="color:rgb(219,219,219)">H</span>
<br>
<span class="gradientizer-done" style="color:rgb(109,109,109)">l</span>
</p>

Basically, the revert function intended to change all the gradientizer-done class to text , that is I expect the follow result when running revert on $(".grad2").revert():

<p class="grad2" one="ffffff" second="000000">
 H<br>l</p>

But i see no change in <p></p>

Avinash Raj · Accepted Answer · 2015-02-16 11:48:07Z

2

You have put a single quote after style= attribute instead of double quotes and also you forget to put double quotes at the end of style attribute.

$(this).html().replace(/<span class="gradientizer-done" style="color:rgb\(\d{1,3},\d{1,3},\d{1,3}\)">.<\/span>/g,'');
                                                              ^                                    ^

answered Feb 16, 2015 at 11:48

Avinash Raj

175k32 gold badges247 silver badges289 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

frunkad Over a year ago

Thank you very much. Just noted that I also forgot the capture group and $1

Avinash Raj Over a year ago

capturing group? where? your regex doesn't have any capturing group.

frunkad Over a year ago

Am saying i forgot to add that to make my function work properly.. Nvm

intale · Accepted Answer · 2015-02-16 12:28:47Z

2

Better solution would be:

var $container = $(".grad2");
$container.find(".gradientizer-done").each(function(){
  $(this).after($(this).text())
  $(this).remove()
})

answered Feb 16, 2015 at 12:28

intale

8316 silver badges8 bronze badges

Collectives™ on Stack Overflow

Regex not replacing text in JS

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related