Passing parameters to shell script from a python program

Question

I would like to call a shell script from my python script. I need to pass 3 parameters/arguments to the shell script. I am able to call the shell script (that is in the same directory as that of the python script), but having some issue with the parameter passing

from subprocess import call

// other code here.
line = "Hello"
// Here is how I call the shell command
call (["./myscript.sh", "/usr/share/file1.txt", ""/usr/share/file2.txt", line], shell=True)

In my shell script I have this
#!/bin/sh

echo "Parameters are $1 $2 $3"
...

Unfortunately parameters are not getting passed correctly.

I get this message:

Parameters are 

None of the parameter values are passed in the script

Works fine with shell=False, the recommended use -- why do you think you need shell=True instead?! — Alex Martelli
– Alex Martelli, Commented Feb 18, 2015 at 6:09

vks · Accepted Answer · 2015-02-18 06:17:13Z

2

call ("./myscript.sh /usr/share/file1.txt /usr/share/file2.txt "+line, shell=True)

When you are using shell=True you can directly pass the command as if passing on shell directly.

edited Feb 18, 2015 at 6:17

answered Feb 18, 2015 at 6:04

vks

68.1k11 gold badges96 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user3803714 Over a year ago

Yes, I tried doing that and it works fine except for the last argument. I see this in my script: Parameters are: /usr/share/file1.txt /usr/share/file2.txt line I would like to have: /usr/share/file1.txt /usr/share/file2.txt Hello

user3803714 Over a year ago

Yes, I did this: cmd = "./myscript.sh /usr/share/file1.txt /usr/share/file2.txt" + " " + line call([cmd],shell=True). That worked fine.

jfs Over a year ago

shell=True is unnecessary here. Also, it may break if line contains shell metacharacters such as $`!.

jfs · Accepted Answer · 2015-02-19 01:25:24Z

0

Drop shell=True (you might need to make myscript.sh executable: $ chmod +x myscript.sh):

#!/usr/bin/env python
from subprocess import check_call

line = "Hello world!"
check_call(["./myscript.sh", "/usr/share/file1.txt", "/usr/share/file2.txt", 
            line])

Do not use a list argument and shell=True together.

answered Feb 19, 2015 at 1:25

jfs

417k210 gold badges1k silver badges1.7k bronze badges

Collectives™ on Stack Overflow

Passing parameters to shell script from a python program

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related