Array Index out of bounds when reading from CSV file

Question

I'm trying to read a CSV file using a BufferedReader, but for some reason I get an out of bounds exception after 7 rows. I tried this exact algo on another CSV file (30 rows) and it worked fine. Here is the CSV file in question.

    String spellPath = "file path is here";

    FileReader y = new FileReader(spellPath);
    BufferedReader x = new BufferedReader(y);
    ArrayList<Card> ArrayList = new ArrayList<Card>( );   //dynamic data type

    for( String p = x.readLine(); p != null ; p = x.readLine()){

        String [] stArray = p.split(",");
        ArrayList.add(new Card( stArray[1], stArray[2])); //new card with name and desc only

    }

    System.out.println(ArrayList.toString());

Is the problem with the file or is it with the algorithm?

use this type of loopwhile((String s = br.readLine()) != null) instead of for loop — Bhargav Modi
– Bhargav Modi, Commented Feb 18, 2015 at 14:10
At least one of your lines doesn't have a comma in it. It looks like you have a newline in the middle of one of your rows. — khelwood
– khelwood, Commented Feb 18, 2015 at 14:12

evomiester · Accepted Answer · 2015-02-18 15:44:36Z

3

Your issue here is the 2 consecutive calls to p=x.readLine()

for( String p = x.readLine(); p != null ; p = x.readLine()){
    ...
}

Due to this, 2 lines are read and only 1 is checked for null

You need to change the loop to

while (true) {
    String p= x.readLine();
    if (p == null) break;

    ...
}

answered Feb 18, 2015 at 15:44

evomiester

413 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jens · Accepted Answer · 2015-02-18 14:13:29Z

2

There is one line "gains 500 ATK and DEF for each Spell Card you have on the field." that do not contain any ,. So stArray[] has a length of 1.

Other thing: Java arrays are zero base.

And for( String p = x.readLine(); p != null ; p = x.readLine()){ should be while ((String p = x.readLine())!= null ){

answered Feb 18, 2015 at 14:13

Jens

69.6k15 gold badges107 silver badges133 bronze badges

Comments

Rahul T · Accepted Answer · 2015-02-18 14:12:41Z

1

Try this.

while(x.readLine() != null){
---`enter code here`
}

answered Feb 18, 2015 at 14:12

Rahul T

881 silver badge5 bronze badges

Comments

Bhargav Modi · Accepted Answer · 2015-02-18 14:13:02Z

1

while((String p = x.readLine()) != null){

    String [] stArray = p.split(",");
    ArrayList.add(new Card( stArray[0], stArray[1])); //new card with name and desc only

}

System.out.println(ArrayList.toString());

this should works

answered Feb 18, 2015 at 14:13

Bhargav Modi

2,6553 gold badges33 silver badges50 bronze badges

Comments

Robin Chander · Accepted Answer · 2015-02-18 14:18:36Z

1

You are calling x.readLine()twice in the loop. Hence you are skipping lines while reading.

Better way would be to use CSVReader rather than the buffered reader.

CSVReader reader = new CSVReader(new FileReader(fName), ',','"','|');
    List content = reader.readAll();//do not use this if CSV file is large
    String[] row = null;

    for (Object object : content) {
        row = (String[]) object;
        row = Arrays.toString(row).split(",");
        //now you have a row array with length equal to number of columns
    }

Here is the link to get CSVReader - CSVReader Download

edited Feb 18, 2015 at 14:18

answered Feb 18, 2015 at 14:12

Robin Chander

7,4753 gold badges30 silver badges42 bronze badges

Comments

Fahim · Accepted Answer · 2015-02-18 14:11:44Z

0

Error is throwing here

String [] stArray = p.split(",");
 ArrayList.add(new Card( stArray[1], stArray[2]));

Add this condition and check

String [] stArray = p.split(",");
ArrayList.add(new Card( stArray[0], stArray[1]));

answered Feb 18, 2015 at 14:11

Fahim

12.4k5 gold badges42 silver badges57 bronze badges

1 Comment

DmitryKanunnikoff Over a year ago

The answer is the right to life, as sets the right direction.

Collectives™ on Stack Overflow

Array Index out of bounds when reading from CSV file

6 Answers 6

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related