Making a new array considered a Dynamic Assignment Ruby

Question

I want to make an array where to keep scores for every user. An example of the array would be ScoreArray["[email protected]"] = 10. To do this I need to instantiate the Array first. So I tried something like:

ScoreArray = Array.new

    @sugested.each do |gg|
      nr = 0
      @followees.each do |ff|
        if (ff.email == gg.email) then nr = nr + 1
        end
      end
      if(gg.following.count != 0) then
        score = ( nr/@followees.count ) * ( gg.followers.count / gg.following.count)
        ScoreArray[gg.email] = score
        pry.bind
      else score = 0
      end 
    end

All this code is inside a method called candidates . When I try to run rails server I get the following error message on the page where I invoke this method :

home/flo/Ruby/Licenta/honk_app/app/controllers/application_controller.rb:45: dynamic constant assignment ScoreArray = Array.new ^

Any ideas how can I avoid this problem? And why is it doing this?(from what I've read is because it's inside a method and ruby doesn't like instantiating a "constant" each time a method is called. The thing is , this is not a constant ... for each user that logs in I will have a separate array).

What is the scope of this array (i think you actually want a hash) supposed to be? — Frederick Cheung
– Frederick Cheung, Commented Feb 22, 2015 at 10:40
I did want to make a hash first. But I have to order it by score(the values in it) after, so I decided an Array would be better . The order is necessary because I will have to show Users in order based on that score — Lucian Tarna
– Lucian Tarna, Commented Feb 22, 2015 at 10:41
U can try something like this Hash[actual_hash.sort_by{|k, v| v}.reverse], this will give you a hash sorted by values, in your case score is a value — Sonalkumar sute
– Sonalkumar sute, Commented Feb 22, 2015 at 10:46
@Sontya it returns a hash ? And if I do .each on that Hash I get the elements in order(by score) ? — Lucian Tarna
– Lucian Tarna, Commented Feb 22, 2015 at 10:52
If you don't want a constant, why make it a constant? (if it starts with an uppercase letter it's a constant) — Frederick Cheung
– Frederick Cheung, Commented Feb 22, 2015 at 10:55

Frederick Cheung · Accepted Answer · 2015-02-22 11:04:29Z

2

In ruby a leading capital letter denotes a constant - if you don't want a constant then start with a lowercase letter (if a local variable isn't sufficient for your purpose, consider an instance variable)

In addition arrays can't be used as you show them

some_array[gg.email]

Will raise an exception if gg.email is a string

answered Feb 22, 2015 at 11:04

Frederick Cheung

84.3k9 gold badges157 silver badges175 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lucian Tarna Over a year ago

true indeed :P I changed it back to a hash and did as Sontya told me :P .

Sonalkumar sute · Accepted Answer · 2015-02-22 18:07:32Z

1

Try this

score_hash = Hash.new
score_hash[gg.email] = score
sorted_hash = Hash[score_hash.sort_by{|k, v| v}.reverse]

edited Feb 22, 2015 at 18:07

answered Feb 22, 2015 at 10:51

Sonalkumar sute

2,5402 gold badges19 silver badges29 bronze badges

1 Comment

Lucian Tarna Over a year ago

dynamic constant assignment ScoreHash = Hash.new it still has the same dynamic constant assignment error

Collectives™ on Stack Overflow

Making a new array considered a Dynamic Assignment Ruby

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related