Changing iframe source within multiple tags. javascript function isn't working

Question

I'm trying to execute a javascript function that would change the source code for each iframe. It works if the iframe is not within any other tags.

<!DOCTYPE html>
<html>
<head>
<link href="css/bootstrap.min.css" rel="stylesheet">
</head>
<body>
<button onclick="myFunction()">Search</button>
<iframe src="https://www.espn.com"  frameborder="1"  width="500" height="320"></iframe>
<iframe src="https://www.nbc.com"  frameborder="1"  width="500" height="320"></iframe>
<iframe src="https://www.cnn.com"  frameborder="1" width="500" height="320"></iframe>
 <script type = "text/javascript">
  function myFunction(){
  alert("Hello!");
  var frames = window.frames;
  for (var i = 0; i < frames.length; i++){
    frames[i].location = "http://www.w3schools.com";
    }  
}
</script>
</body>
</html>

How ever if I put the iframe within div tags the javascript for some reason doesn't reach them.

<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">
<link href="css/bootstrap.min.css" rel="stylesheet">
</head>
<body>
 <div class="container-fluid">
    <form align = "center">
      <br>
      <button onclick="myFunction()">Search</button>
      <br>
    </form>
<div class="col-xs-8 col-lg-6">
    <h3 id = "ESPN">ESPN</h3>
       <iframe src="https://www.espn.com"  frameborder="1"  width="500" height="320"></iframe>
      <br>
    </div>
    <div class="col-xs-8 col-lg-6">
    <h3 id = "NBC">NBC</h3>
      <iframe src="https://www.nbc.com"  frameborder="1"  width="500" height="320"></iframe>
      <br>
    </div>
    <div class="col-xs-8 col-lg-6">
    <h3 id = "CNN">CNN</h3>
      <iframe src="https://www.cnn.com"  frameborder="1" width="500" height="320"></iframe>
      <br>
</div>
</div>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.2/jquery.min.js"></script>
 <script src="js/bootstrap.min.js"></script>
 <script type = "text/javascript">
  function myFunction(){
  alert("Hello!");
  var frames = window.frames;
  for (var i = 0; i < frames.length; i++){
    frames[i].location = "http://www.w3schools.com";
    }  
}
</script>
</body>
</html>

Is there something else I need to do in order for my function to read the iframes?

TheSuper · Accepted Answer · 2015-02-23 17:06:01Z

2

  function myFunction(){
  alert("Hello!");
  var frames = window.getElementsByTagName("iframe"); // You only want iframes
  for (var i = 0; i < frames.length; i++){
    frames[i].src = "http://www.w3schools.com";
    }  
}

answered Feb 23, 2015 at 17:06

TheSuper

6557 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alexis Peters · Accepted Answer · 2015-02-23 17:05:23Z

1

 var frames = window.querySelectorAll("iframe");

to get all iframes. Im not sure but you may also change your line to
frames[i].src = "http://www.w3schools.com";

answered Feb 23, 2015 at 17:05

Alexis Peters

1,6511 gold badge11 silver badges17 bronze badges

Comments

Pedro Monteiro · Accepted Answer · 2015-02-23 17:06:29Z

0

Try this

frames[i].src= "http://www.w3schools.com";

insted of that

frames[i].location = "http://www.w3schools.com";

answered Feb 23, 2015 at 17:06

Pedro Monteiro

3373 silver badges17 bronze badges

Comments

Syed Mazhar Mazzi · Accepted Answer · 2015-02-23 17:13:18Z

0

You need to replace your javascript with the following:

function myFunction() {
            alert("Hello!");
            var frames = document.getElementsByTagName("iframe");
            for (var i = 0; i < frames.length; i++) {
                frames[i].src = "http://www.w3schools.com";
            }
        }

answered Feb 23, 2015 at 17:13

Syed Mazhar Mazzi

16

2 Comments

mccainz Over a year ago

For clarity, could you explain what the mistake in the original code was that your solution addresses?

Syed Mazhar Mazzi Over a year ago

Well, there's nothing wrong in your code. Bt since document.getElementByTagName is restricted to look in only the document object of which it is a method, It is more elegant method. By the way, your code worked without any problem here...

Collectives™ on Stack Overflow

Changing iframe source within multiple tags. javascript function isn't working

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related