Error when passing JSON string to MVC Controller

Question

It's verys simple situation in fact, but I can't find solution: I need pass JSON string to my MVC Controller via jQuery ajax but Controller always receive null. Here is the jQuery:

$("#makebooking").click(function (e) {
            var json;
            if ($("form").valid()) {
                var arr = $("form").serializeArray();
                json = JSON.stringify({ 'command': arr });
            }
            $.ajax({
                url: "@Url.Content("~/Booking/CreateBooking")",
                data: json,
                type: "post",
                cache: false,
                dataType: "json",
                success: function (result) {
                    if (result != null) {
                        window.location = result;
                    } else {
                        $("#modalerror").on("show.bs.modal", function () {
                            var modal = $(this);
                            modal.find("#errormsg").text(result.Error);
                        });
                    }
                },
                error: function (xhr) {
                    var err = eval("(" + xhr.responseText + ")");
                    alert(err.Message);
                }
            });

And Controller code is here:

        [HttpPost]
        public JsonResult CreateBooking(string command)
        {           
            byte[] stream = HttpServerUtility.UrlTokenDecode(Request.Cookies["psw"].Value);
            byte[] decodedValue = MachineKey.Unprotect(stream, "all");
            var psw = Encoding.UTF8.GetString(decodedValue);
            var a = _br.CreateBooking(User.Identity.Name, psw, command);
            return Json(a);
        }

I hope someone can have fresh look at this code and advise solution. Thanks.

Why are you posting a string (as opposed to posting your model)? — user3559349
– user3559349, Commented Feb 28, 2015 at 11:15
@StephenMuecke, I'm not sure what you mean. Can you explain please? — andrey.shedko
– andrey.shedko, Commented Feb 28, 2015 at 11:16
The parameter in you method is string command? You have a form which I assume is based on a model, in which case you should post back you model using data: $('form').serialize(), and the method should be` public JsonResult CreateBooking(YourModel model)` — user3559349
– user3559349, Commented Feb 28, 2015 at 11:21
Yes, form based on ViewModel. Just now I tired to use model as parameter but without success - all data are null. — andrey.shedko
– andrey.shedko, Commented Feb 28, 2015 at 11:28
One more reason why I'm using string - I need process this data in order to re-create its as urlencoded string for calling external web service. — andrey.shedko
– andrey.shedko, Commented Feb 28, 2015 at 11:29

user3559349 · Accepted Answer · 2015-02-28 11:42:49Z

1

The parameter of you POST method is string but you posting back json.

Change the method to

[HttpPost]
public JsonResult CreateBooking(YourModel model)

and the script to

if ($("form").valid()) {
  var json = $('form').serialize(); // serialize the form values to json
  $.ajax({
    url: '@Url.Action("CreateBooking", "CreateBooking")', // recommended
    data: json,
    ....

You model will be correctly bound in the POST method

answered Feb 28, 2015 at 11:42

user3559349

Sign up to request clarification or add additional context in comments.

Comments

hobenkr · Accepted Answer · 2015-02-28 11:15:30Z

0

I'm not sure if this is the entirety of your problem, but it looks like the url in your ajax call has a problem with the quotes. Try mixing single quotes with double quotes such as

url: "@Url.Content('~/Booking/CreateBooking')"

answered Feb 28, 2015 at 11:15

hobenkr

1,23411 silver badges30 bronze badges

6 Comments

andrey.shedko Over a year ago

Definitely it's not the source of this issue.

hobenkr Over a year ago

Have you tried using the inspector in chrome or firefox to check the call being made to the server?

andrey.shedko Over a year ago

Yes. I see that json data passed to ajax call, but missed somewhere between jQuery and Controller.

user3559349 Over a year ago

@hobenkr, This makes no difference (although its normal to use url: '@Url.Action("CreateBooking", "Booking")',

hobenkr Over a year ago

@stephenmuecke, you're right. Thanks for the correction. Andrey, I'm not familiar with asp, but do you get a response from the server in inspector? Maybe an error message or something?

|

Collectives™ on Stack Overflow

Error when passing JSON string to MVC Controller

2 Answers 2

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related