sqlite syntax error when updating with string value Android

Question

public class Profile implements Parcelable {

public final static String ACCOUNTS_TABLE_NAME = "accounts";
public final static String FIELD_DISPLAY_NAME = "displayname";
public final static String FIELD_IP = "ipaddress";
}



String f1 = "planet";
String ip = "udp:85.59.123.78:289";

My update query is like below

db.execSQL("UPDATE " + Profile.ACCOUNTS_TABLE_NAME + " SET " + SipProfile.FIELD_IP+ "="+ip +" WHERE "+ Profile.FIELD_DISPLAY_NAME + "=" + f1);

i am getting below error

03-14 09:28:59.720: E/SQLiteLog(13321): (1) near ":85": syntax error

Well, first, you're using concatenation to create SQL and are therefore quite possibly risking injection attacks and so on. But besides that, you aren't quote-delimiting the IP address. — Nathan Tuggy
– Nathan Tuggy, Commented Mar 14, 2015 at 4:27

Fahim · Accepted Answer · 2015-03-14 04:20:08Z

1

Use this, in where clause ip and f1 values should be in single quotes

db.execSQL("UPDATE " + Profile.ACCOUNTS_TABLE_NAME + " SET " + SipProfile.FIELD_IP+ "='"+ip +"' WHERE "+ Profile.FIELD_DISPLAY_NAME + "='" + f1+"'");

answered Mar 14, 2015 at 4:20

Fahim

12.4k5 gold badges42 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

sqlite syntax error when updating with string value Android

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related