Local variable returned in recursive function

Question

i have written a code for a fibonacci series returning the sum of the complete series, can the local "static int" variable be returned to the main function where the code is trying to print the sum.

Below is my code

#include<stdio.h>


int fiborecur(int n)
{
    static int first=0,second=1,sum=0,total=0;
    if( n>0 )
    {
        sum = first + second;
        total = total + sum;
        printf("  %d", sum);
        first = second;
        second = sum;
        fiborecur(n-1);
    }
    else
    {
        return total+1;
    }
}
int main()
{
    int n;
    printf("Enter the series length you want = ");
    scanf("%d", &n);
    printf("0  1");
    printf("\nSum of the series after return = %d\n", fiborecur(n-2));
    return 0;
}

you are not returning a static int, you are returning its value, so yes. but this looks like it will fail on a second invocation, since nothing resets the statics — sp2danny
– sp2danny, Commented Mar 14, 2015 at 4:29
you can return without recursive function it will work fine.. Do you need with recursive function? — Rajalakshmi
– Rajalakshmi, Commented Mar 14, 2015 at 5:43

Tim · Accepted Answer · 2015-03-14 04:31:28Z

2

Why are your int values declared as static? Use your return value to return the current total, and then it will happen automatically.

Static values plus recursion is a recipe for disaster.

answered Mar 14, 2015 at 4:31

Tim

2,9321 gold badge17 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ishamael · Accepted Answer · 2015-03-14 04:31:35Z

-1

Your problem is that you only return the total if n == 0, but your main function actually calls it with n > 0. Make your function always return total + 1, not only when n is zero (in other words just remove the else), and it should work.

answered Mar 14, 2015 at 4:31

Ishamael

12.8k4 gold badges38 silver badges53 bronze badges

Collectives™ on Stack Overflow

Local variable returned in recursive function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related