Using variables in Javascript.replace

Question

I am trying to inject the replace method for javascript in webview for android.

This code works:

       {
            mWebView.loadUrl("javascript:(function(){" +
                    "document.body.innerHTML = document.body.innerHTML.replace('hello', 'hi');" +
                    "})()");
            }

Instead of putting the string in the method, however, I want to use variables. I tried using regex but it does not seem to work.

        {
            String old = "hello";
            String new = "hi";

            mWebView.loadUrl("javascript:(function(){" +
                    "var ol = new RegExp(old,'g');" +
                    "document.body.innerHTML = document.body.innerHTML.replace(ol, new);" +
                    "})()");
            }

Is there something off with my code?

new RegExp(" + old + ",'g') and .replace(ol, " + new + "); — blex
– blex, Commented Mar 18, 2015 at 21:21
var doesnt seem to recognize the text inside as a string...any way to fix that? — John Olsen
– John Olsen, Commented Mar 19, 2015 at 0:01

adeneo · Accepted Answer · 2015-03-18 21:21:16Z

2

You have to quote out the variables when passing them into a string like that

{
    String old  = "hello";
    String _new = "hi";

    mWebView.loadUrl("javascript:(function(){" +
                    "var ol = new RegExp("+old+",'g');" +
                    "document.body.innerHTML = " +            
                    "document.body.innerHTML.replace(ol, " +_new+ ");" +
                    "})()"
    );
}

Note that new is a reserved keyword, and shouldn't be used as a variable name

answered Mar 18, 2015 at 21:21

adeneo

319k29 gold badges410 silver badges392 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

John Olsen Over a year ago

sorry, i thought this would work and marked it as answer but it ended up not working when i put it in my code.

Collectives™ on Stack Overflow

Using variables in Javascript.replace

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related