access to variable within inner class in Android

Question

i'm trying to generate a set of buttons whith data from the database. But on click i'm facing the following eror

Variable 'i' is accessed from within the inner class, needs to be declared final,

Since the value of i is changes as loop goes on i cannot set it as final,

footnoteBtns[i].setOnClickListener(new View.OnClickListener() {

                @Override
                public void onClick(View v) {

                    footnote = myDbHelper.getFootnote(chapterNumber, translationList.get(i).get("transNo"));

                    Popup();
                }
            });

Yes. Do you understand that you rewriting listener on each step on loop? — Divers
– Divers, Commented Mar 21, 2015 at 23:34

flogy · Accepted Answer · 2015-03-21 22:47:51Z

1

You could add an additional variable that is final and set to i:

final int j = i;

And then use that one inside the overridden onClick method.

The reason why you have to do this, is that onClick is called at another point of time and not directly inside the for loop -> asynchronous. Therefore, you need to make sure that it is clear which value should be used in that later called method. That's why the variable needs to be final.

answered Mar 21, 2015 at 22:47

flogy

9454 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Divers · Accepted Answer · 2015-03-21 22:48:48Z

0

In general it very weird approach to put setOnClickListener in a loop, but in your case you can solve it with following code:

    for( int i = 0; i < N; i++) {
           final int p = i;
           footnoteBtns[p].setOnClickListener(new View.OnClickListener() { 

                @Override 
                public void onClick(View v) {
                    footnote = myDbHelper.getFootnote(chapterNumber,    translationList.get(p).get("transNo")); 
                    popup(); 
                } 
            }); 
}

answered Mar 21, 2015 at 22:48

Divers

9,5797 gold badges48 silver badges90 bronze badges

Comments

Kirill K · Accepted Answer · 2015-03-21 22:51:42Z

0

Try this in place of current code:

class MyOnClickListener extends View.OnClickListener {
    private int myi;

    public MyOnClickListener(int i) {
        myi = i;
    }

    @Override
    public void onClick(View v) {

        footnote = myDbHelper.getFootnote(chapterNumber, translationList.get(myi).get("transNo"));

         Popup();
    }
};

footnoteBtns[i].setOnClickListener(new MyOnClickListener(i));

answered Mar 21, 2015 at 22:51

Kirill K

7816 silver badges19 bronze badges

Collectives™ on Stack Overflow

access to variable within inner class in Android

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related