Why does my method return an array of nulls?

Question

I'm using a foreach loop to iterate over an empty array, and populate it with objects. "Case" is a class with several methods and attributes.

My code looks like this:

public class Test {

private Case [] list = new Case[5];

public Case [] test(){
    for(Case myCase : list){
        myCase = new Case(); 
    }

    return list; //This list contains 5 nulls, but should contain five "Case" objects.
}

public static void main(String[] args){
    Test myTest = new Test();
    myTest.test();
}}

The list which is returned from my method contains 5 nulls, when I expect it to contain 5 instantiated "Case" objects. I suspect this might be some sort of visibility problem, but I can't figure it out.

dbank · Accepted Answer · 2015-03-22 06:10:26Z

9

The variable used in a for-each loop is just a reference to the current value of the array element. Assigning to that variable does not affect the values stored in the array. You need to use a for loop like this:

for (int i = 0; i < list.length; i++) {
    list[i] = new Case();
}

edited Mar 22, 2015 at 6:10

dbank

1,2131 gold badge18 silver badges29 bronze badges

answered Mar 22, 2015 at 3:42

Brett Kail

34k2 gold badges88 silver badges93 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Benjamin Winters Over a year ago

Correct. If you are wondering how a for each loop works in java check this link. (stackoverflow.com/questions/85190/…)

Nishit · Accepted Answer · 2015-03-22 06:42:42Z

0

Also, You don't need to explicitly return the list from the test() method, since it's a field in myTest.

This would work perfectly fine,

public void test(){
            for(int i=0;i<5;i++){
                this.list[i] = new Case(); 
            }
        }

answered Mar 22, 2015 at 6:42

Nishit

1,3642 gold badges11 silver badges27 bronze badges

Collectives™ on Stack Overflow

Why does my method return an array of nulls?

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related