Using multiple structs through header files C++

Question

Apologies if you have seen this question before however it has yet to be answered, essentially in my code I have two structs, defined in separate headers and used globally throughout the project. I simply wish to use both structs (which again, are defined in two separate headers) in other cpp files than just the ones that the header file belongs to. Here is some sample code which I have tested:

class1.h

    #include "class2.h"
    #include <vector>
    #include <string>

    struct trans1{
        string name;
    };
    class class1 {

    private:
        vector <trans2> t2;

    public:
        class1();
    };

class2.h

    #include "class1.h"
    #include <vector>
    #include <string>        

    struct trans2{
        string type;
    };

    class class2{

    private:
        vector <trans1> t1;

    public:
        class2();
    };

errorlog:

    In file included from class1.h:3:0,
                     from class1.cpp:1:
    class2.h:21:13: error: 'trans1' was not declared in this scope
         vector <trans1> t1;
                 ^
    class2.h:21:19: error: template argument 1 is invalid
         vector <trans1> t1;
                       ^
    class2.h:21:19: error: template argument 2 is invalid

I understand that this is ridiculous code in a real world application however this is the simplest way I could demonstrate.

It is worth noting that if I simply comment out the declaration of vector t1 or t2 under 'private:' the code compiles without fail. It is just the fact I am using a second struct.

Any help anyone? Thanks.

Can you put the "trans" structs in their own header file?

Neil Kirk
– Neil Kirk

2015-03-22 19:28:41 +00:00
Commented Mar 22, 2015 at 19:28 — Neil Kirk
– Neil Kirk, Commented Mar 22, 2015 at 19:28
possible duplicate of Using a struct across classes in c++

erip
– erip

2015-03-22 19:48:21 +00:00
Commented Mar 22, 2015 at 19:48 — erip
– erip, Commented Mar 22, 2015 at 19:48

Richard Hodges · Accepted Answer · 2015-03-22 19:31:29Z

1

Simply forward-declare the classes that will be used. Put all implementation code into a cpp file, not inline in the header.

Make the vector private. This way no file that includes the header can force code generation against an incomplete class.

answered Mar 22, 2015 at 19:31

Richard Hodges

70.3k8 gold badges103 silver badges157 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Neil Kirk Over a year ago

The vectors require a full declaration of the structs. This won't work unless the vectors are changed to store pointers.

Richard Hodges Over a year ago

I can confirm that this technique does actually work even though the class is not fully defined at the point of the declaration of the vector. tutorialspoint.com/…

Richard Hodges Over a year ago

As I understand it there is (or was) some disagreement in the standards committee about whether it should be allowed. The arguing for allowing it, surprisingly, makes vector easier to implement efficiently. I think as things stand, what I have done should not work according to a strict standards interpretation, but in fact always does. The things you learn eh? :)

Neil Kirk Over a year ago

stackoverflow.com/questions/29262292/…

Maxim Busel · Accepted Answer · 2015-03-22 19:34:35Z

0

you can try to forward declare trans1 in class2.h and trans2 in class1.h like this:

class2.h :

// includes
struct trans1;
// rest of your code

the same thing (but with trans2) in class1.h

Don't forget to add Include guards in your code!

edit: and yes, you need to change your vectors to store pointers, otherwise it won't link

answered Mar 22, 2015 at 19:34

Maxim Busel

1

1 Comment

Neil Kirk Over a year ago

I think this is worse because now you have to worry about how to allocate and delete the vector objects.

Neil Kirk · Accepted Answer · 2015-03-22 19:42:55Z

0

You need to put the "trans" structs in their own header file(s) and include them in your class header files.

You could forward declare them, but this would require changing your vector to use pointers. (In that case I would recommend std::vector<std::unique_ptr<trans>>). This could be appropriate if your structs are big and complex.

The main advantage of the forward-declaration approach is to reduce compile times. However if the structs are really so simple as in your example, I wouldn't bother with the extra overhead of using pointers here.

answered Mar 22, 2015 at 19:42

Neil Kirk

22k9 gold badges57 silver badges96 bronze badges

Comments

tp1 · Accepted Answer · 2015-03-22 19:51:11Z

0

If You were to do this in single .cpp file, the solution would be trivial:

   struct trans1 { ... };
   struct trans2 { ... };
   class class1 { ... };
   class class2 { .... };

Now you just need to rearrange the code to get this result in every translation unit. (the order of classes/structs in the file is important)

edited Mar 22, 2015 at 19:51

answered Mar 22, 2015 at 19:39

tp1

1,20712 silver badges19 bronze badges

Collectives™ on Stack Overflow

Using multiple structs through header files C++

4 Answers 4

4 Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related