javascript window.open and adding parameters

Question

I'm having some issues with my javascript link

I have a hidden input fields with the name "domein"

I'm having the following div with a onclick script

<div id="button" onclick="window.open('http://www.mylink.nl/?domein=' + document.getElementById('domein').value ,'_blank') ">
<strong>button text</strong>
</div>

The link does not open in a new tab neither does it shows the values from the 'domein' value from the hidden field in the url.

Can you guys please help me out?

My second question: How can I let the url be only http://www.mylink.nl when 'domein' value = empty.

Did you have a look at this: stackoverflow.com/questions/4907843/…? — Tom Nijs
– Tom Nijs, Commented Mar 30, 2015 at 14:05

brso05 · Accepted Answer · 2015-03-30 14:16:52Z

1

This works:

<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>Untitled Document</title>
</head>
<body>
<input type="hidden" id="test" value="test">
<div id="button" onclick="window.open('http://www.example.com/?domein=' + document.getElementById('test').value,'_blank');">
<strong>button text</strong>
</div>
</body>
</html>

New tab url:

http://www.example.com/?domein=test

Please check and make sure you have your hidden input defined with id domein...

******************************UPDATE********************************

<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>Untitled Document</title>
</head>
<body>
<script type="text/javascript">
function submit()
{
    if(!document.getElementById("test").value.match(/\S/))
    {
        window.open('http://www.example.com/','_blank');
    }
    else
    {
        window.open('http://www.example.com/?domein=' + document.getElementById('test').value,'_blank');
    }
}
</script>
<input type="hidden" id="test" value="test">
<div id="button" onclick="submit()">
<strong>button text</strong>
</div>
</body>
</html>

edited Mar 30, 2015 at 14:16

answered Mar 30, 2015 at 14:11

brso05

13.3k2 gold badges25 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Elvira Over a year ago

My second question: How can I let the url be only mylink.nl when 'domein' value = empty.

Elvira Over a year ago

Thank you, I didn't had a hidden field on that particular page indeed.. do you mind answering my second question? :)

Elvira Over a year ago

My second question: How can I let the url be only mylink.nl when 'domein' value = empty. –

Collectives™ on Stack Overflow

javascript window.open and adding parameters

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related