Perl: foreach array of strings, split strings, set each string to a new array

Question

I've got a string input, lets say it's:

junk 0 0 :::1000
junk 0 0 :::1001
junk 0 0 :::1002
junk 0 0 :::1009

I want only the last digit of the 100X number, and I want to place it in a string, and populate an array with these strings.

I have the following code

my @lines = split /^/, $input;

foreach my $line (@lines)
{
  my ($garb, $long_ports)  = (split /\s*:::\s*/, $line);

  my ($garb2, $ports) = (split /10/, $long_ports);

  if ($ports < 10)
  {
    my ($garb3, $ports2) = (split /0/, $ports);

    #Add 0 since 0 port is split to empty string
    if (length($ports2) == 0)
    {
      $ports2 = "0$ports2";
    }

    #Create file name format
    @locked_ports = ".X$ports2-lock";
  }
}

When I print "@locked_ports" I only get the value .X9-lock, when I want all 4.

How do I make it so @locked_ports contains all 4 of the strings?:

.X0-lock
.X1-lock
.X2-lock
.X9-lock

Christopher Bottoms · Accepted Answer · 2015-04-03 16:42:05Z

2

You simply need to use push to add each desired result to the end of the array. Here's an example snippet:

foreach my $line (@lines) {
    chomp $line;
    if ($line =~ /(\d)$/) {
        push @ports, ".X$1-lock";
    }
}

edited Apr 3, 2015 at 16:42

Christopher Bottoms

11.4k11 gold badges60 silver badges107 bronze badges

answered Apr 2, 2015 at 21:53

Ron Bergin

1,0681 gold badge6 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

leu · Accepted Answer · 2015-04-02 21:23:02Z

1

it runs, when you modify your code as follows

my @lines = split /^/, $input;

foreach my $line (@lines)
{
 chomp($line);
 my ($garb, $long_ports)  = (split /\s*:::\s*/, $line);

 my ($garb2, $ports) = (split /10/, $long_ports);

 if ($ports < 10)
 {
   my ($garb3, $ports2) = (split /0/, $ports);
   #Add 0 since 0 port is split to empty string
   if (length($ports2) == 0)
   {
     $ports2 = "0$ports2";
   }

   #Create file name format
   push @locked_ports, ".X$ports2-lock";
  }
}

you have to push the locks at the end of @locked_ports and to chomp the $line to get rid of newlines

answered Apr 2, 2015 at 21:23

leu

2,1232 gold badges12 silver badges27 bronze badges

Comments

salparadise · Accepted Answer · 2015-04-02 21:21:05Z

1

one quick thing to try is change this:

 @locked_ports = ".X$ports2-lock";

to:

push @locked_ports,"X${ports2}-lock";

Also make sure you are using use strict' and use warnings; and post the snippet where you declare @locked_ports and print it.

answered Apr 2, 2015 at 21:21

salparadise

5,8751 gold badge28 silver badges32 bronze badges

Collectives™ on Stack Overflow

Perl: foreach array of strings, split strings, set each string to a new array

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related