else part not executing in php if condition

Question

I've got this project on DBMS. My form is working if I enter the correct username and password.. but it shows only a blank page when i enter wrong details.. It's not executing the else part.. It if part is working fine.. Can anyone help me.. I'm new to PHP.

<html>
<head>
   <title></title>
</head>
<body>  

 <?php
 include 'connection.php';
 SESSION_START();
 $user = $_POST['registeredEmail'];
 $pass = $_POST['registeredpassword'];
 $sql = "SELECT * FROM users WHERE email = '".$user."' and password = '".$pass."';";
$qry = mysql_query($sql) or die(mysql_error());
$result = mysql_fetch_array($qry) or die(mysql_error());
if($result) 
{
$_SESSION['UserName'] = $result['name'];
echo '<script type="text/javascript">'; 
echo 'alert("Sign In Successful");'; 
echo 'window.location.href = "sell.php";';
echo '</script>';



}
else
{
//  header('Location: index.php');
echo 'sign in unsuccessful';
echo '<script type="text/javascript">'; 
echo 'alert("Sign In UnSuccessful. Either Email or password or both are wrong.. please try again or Sign Up");'; 
echo 'window.location.href = "index.php";';
echo '</script>'; 
}
?>
</body>
</html>

Did you looked into your source code? Is your page really blank ? — Rizier123
– Rizier123, Commented Apr 3, 2015 at 13:02
Please, please, please read this stackoverflow.com/questions/60174/… before you do anything else. — Bart Friederichs
– Bart Friederichs, Commented Apr 3, 2015 at 13:04

Sagar Naliyapara · Accepted Answer · 2015-04-03 13:04:48Z

1

Instead of if($result)

you can use if(mysql_num_rows($qry)>0)

edited Apr 3, 2015 at 13:04

Sagar Naliyapara

4,1915 gold badges43 silver badges62 bronze badges

answered Apr 3, 2015 at 13:03

Muhammad Ahmed

4812 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Guinn Over a year ago

You would want it to be if(mysql_num_rows($qry) ==1) since its a login form, and you dont want more than 1 match

Community · Accepted Answer · 2017-05-23 11:50:44Z

0

There are few problems in your code. Let's 1st focus on how to fix this. Replace your code with below.

$sql = "SELECT * FROM `users` WHERE `email` = '".$user."' and `password` = '".$pass."';";
$qry = mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($qry) == 1) 
{

Your code is vulnerable to SQL injection.

How can I prevent SQL injection in PHP?

Don't store the password in plain-text. Use an encryption algorithm such as md5.

Best way to store password in database

edited May 23, 2017 at 11:50

CommunityBot

11 silver badge

answered Apr 3, 2015 at 13:05

Techie

45.2k45 gold badges164 silver badges248 bronze badges

3 Comments

Bart Friederichs Over a year ago

That, and it seems to store plaintext passwords. I hope this code never sees any real life application.

Techie Over a year ago

That's why I mentioned that code has issues at the beginning

Tushar Anand Over a year ago

I'm just using the code to rum via xampp on localhost.. will comply by your suggestions.. Thanks a ton to all you guys for helping ...

Vivek Singh · Accepted Answer · 2015-04-03 13:03:27Z

<?php
 include 'connection.php';
 SESSION_START();
 $user = $_POST['registeredEmail'];
 $pass = $_POST['registeredpassword'];
 $sql = "SELECT * FROM `users` WHERE `email` = '".$user."' and `password` = '".$pass."';";
$qry = mysql_query($sql) or die(mysql_error());
$num=mysql_num_rows($qry);
if($num==1) 
{
$result = mysql_fetch_array($qry) or die(mysql_error());

$_SESSION['UserName'] = $result['name'];
echo '<script type="text/javascript">'; 
echo 'alert("Sign In Successful");'; 
echo 'window.location.href = "sell.php";';
echo '</script>';



}
else
{
//  header('Location: index.php');
echo 'sign in unsuccessful';
echo '<script type="text/javascript">'; 
echo 'alert("Sign In UnSuccessful. Either Email or password or both are wrong.. please try again or Sign Up");'; 
echo 'window.location.href = "index.php";';
echo '</script>'; 
}
?>

try this

Guinn · Accepted Answer · 2015-04-03 13:10:18Z

0

Basicly your if statement always conditions to true, so the else statement is never reached. If you check a different condition like vivek suggests, where you check if your query has exactly 1 match (since I suppose you will want a user to have only 1 account) the statement can also be false and thus it will skip to the else statement.

answered Apr 3, 2015 at 13:10

Guinn

1,39514 silver badges29 bronze badges

Collectives™ on Stack Overflow

else part not executing in php if condition

4 Answers 4

1 Comment

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related