Setting and Checking cookies with javascript

Question

I have a script that set a cookies once a link is clicked and then when when u visited the page again it will check the cookies and alert that you are already here. However my code doesn't seem to work. Can any1 help out??

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

<html>

<head>
    <title></title>
    <script type="text/javascript">
        function get_cookie("visited"){
            if (document.cookie.indexOf("visited") >= 0) {
                // They've been here before.
                alert("hello again");
            }
    </script>

</head>

<body onload="get_cookie()">

    <script type="text/javascript">
        /*  This function sets the cookie   */
        function iLoveCookies() {
                days = 30; // number of days to keep the cookie
                myDate = new Date();
                myDate.setTime(myDate.getTime() + (days * 24 * 60 * 60 * 1000));
                document.cookie = 'cookieName=visited; expires=' + myDate.toGMTString();
            }
            /*  end of cookie function  */


        
    </script>

    <a href="#" onclick="iLoveCookies()">Set Cookie</a>
</body>
</html>

i took out the } but problem still persit. How exactly i check the cookies that i set in this case. Cause the cookie is being set but not check correctly — Heli
– Heli, Commented Apr 3, 2015 at 18:23

Jason Cust · Accepted Answer · 2015-04-03 18:32:38Z

2

It looks like you basically had typos causing the errors. You might want to use a linter to check your JavaScript or at the least look at your browser's developer console to see what it's telling you.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

<html>

<head>
    <title></title>
    <script type="text/javascript">
        function get_cookie(){
            if (document.cookie.indexOf("visited") >= 0) {
                // They've been here before.
                alert("hello again");
            }
          }
    </script>
  

</head>

<body onload="get_cookie()">

    <script type="text/javascript">
        /*  This function sets the cookie   */
        function iLoveCookies() {
                days = 30; // number of days to keep the cookie
                myDate = new Date();
                myDate.setTime(myDate.getTime() + (days * 24 * 60 * 60 * 1000));
                document.cookie = 'cookieName=visited; expires=' + myDate.toGMTString();
            }
            /*  end of cookie function  */
    </script>

    <a href="#" onclick="iLoveCookies()">Set Cookie</a>
    <a href="#" onclick="get_cookie()">Get Cookie</a>
</body>
</html>

answered Apr 3, 2015 at 18:32

Jason Cust

10.9k2 gold badges36 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jason Cust Over a year ago

Glad to hear it. Just an FYI: there are lots of existing libraries/frameworks that you could use as well.

Collectives™ on Stack Overflow

Setting and Checking cookies with javascript

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related