Javascript string search doesn't work

Question

I need to check if a page contains some text. Here is the code that doesn't work, but i am not able to determine why:

  var st1 = "Not";
  var st2 = "available";
  var tosearch = str1.concat(str2);
  document.write(tosearch);
  var Availability = "not defined";
  if(document.body.innerHTML.toString().indexOf(tosearch) > -1){
       Availability = "yes";
  } else {
     Availability = "fdssssssssssssssssssssssss";
  }

You have st1 and st2 but you are using str1 and str2 ... was that a typo? — callback
– callback, Commented Apr 5, 2015 at 16:06
Because the document.write(tosearch) for example doesn't write enything. — Brana
– Brana, Commented Apr 5, 2015 at 16:06

bvaughn · Accepted Answer · 2015-04-05 16:14:56Z

1

It's probably not working because you declare st1 and st2 but then reference them as str1 and str2. Change to...

  var str1 = "Not";
  var str2 = "available";
  var tosearch = str1.concat(str2);
  // The rest of your code...

You're also creating the string "Notavailable" which is not what you intend to, I think. Maybe try:

  var tosearch = str1 + " " + str2;

You could do the same thing with even less code like so:

if(document.body.innerHTML.toString().indexOf("Not\ available") > -1){
  alert("Yes")
} else {
  alert("No")
}

That being said, it's kind of a mystery to me what you're trying to do with this script. :)

edited Apr 5, 2015 at 16:14

answered Apr 5, 2015 at 16:05

bvaughn

13.5k49 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Brana Over a year ago

I do like this str1 and str2 because otherwise the script would have foundd itself (the word not available). This is why i split it in 2 parts.

Brana Over a year ago

I am atrying to find if page contains "Not available"

bvaughn Over a year ago

FYI you could also declare your string as "Not\ available" if you want to avoid finding a self-match.

Brana Over a year ago

Thanks. It is much shorter.

Collectives™ on Stack Overflow

Javascript string search doesn't work

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related