Inherit from DbSet<TEntity> in Entity Framework Code first NullReference

Question

I would like to implement nlog to each action to add an element. So when I do myContext.Society.Add(), I would like to log something. I create a class DbSetExtension and modify the context StockContext to use DbSetExtension<T> instead DbSet.

public class DbSetExtension<T> : DbSet<T> where T : class
{
    public override T Add(T entity)
    {
        LoggerInit.Current().Trace("Add Done");
        return base.Add(entity);
    }
}

When i launch the programm, I notice when I access to myContext.Society.Add. Society is null. So I think I miss something with my class DbSetExtension but I don't find.

public class StockContext : DbContext
{

    public StockContext()
        : base("StockContext")
    {
    }

    public DbSet<HistoricalDatas> HistoricalDatas { get; set; }
    public DbSet<Society> Society { get; set; }  

    protected override void OnModelCreating(DbModelBuilder modelBuilder)
    {
        modelBuilder.Conventions.Remove<PluralizingTableNameConvention>();           
    }
}

Do you have any idea, Regards, Alex

[UPDATE] Code allows to add. If I replace DbSetExtension by DbSet, the same code works. So my assumption is I miss something when I inherit from DbSet.

    public bool SetSymbols()
    {            
        CsvTools csvThreat = new CsvTools();
        List<Eoddata> currentEnum =
            csvThreat.ExtractData<Eoddata>(ConfigurationManager.GetString("FilePathQuotes", ""));
        currentEnum.ForEach(
            c =>
                {
                    //LoggerInit.Current().Trace("Add Done");
                    Sc.Society.Add(
                        new Society()
                        {
                            RealName = c.Description,
                            Symbol = String.Format("{0}.PA", c.Symbol),
                            IsFind = !String.IsNullOrEmpty(c.Description)
                        });
                });            
        if (Sc.SaveChanges() > 0)
            return true;
        return false;
    }

can you share this part of your code: myContext.Society.Add. — renakre
– renakre, Commented Apr 6, 2015 at 14:39

mr100 · Accepted Answer · 2015-04-06 20:25:00Z

2

In my opinion you took totally wrong direction. DbContext is made to work with DbSet and not DbSetExtension class. It is able to instantiate objects of type DbSet and not your own type. This is basically why you get this exception. Reparing it would require probably hacking EF internals and I fear that this problem will be just a beginning for you. Instead I would recommend you to use general way of logging with EF with use of interceptor classes. Here this is explained in details at the end of article Logging and Intercepting Database Operations. Generally this approach would be much more advantageous for you. Why? Because DbContext is just man-in-the-middle in communication with db. In logs you generally cares about what happens to db and its data. Calling Add method on DbSet may not have any effect at all if SaveChanges won't be called lated on. On contrary query interceptors lets you log strictly only interaction with db. Basing on query sent to db you may distinguish what is going on.

But if you instist on your approach I would recommend you using extension methods instead of deriving from DbSet:

public static class DbSetExtensions
{
    public static T LoggingAdd<T>(this DbSet<T> dbSet, T entity)
    {
        LoggerInit.Current().Trace("Add Done");
        return dbSet.Add(entity);
    }
}

and call it like this:

context.Stock.LoggingAdd(entity);

answered Apr 6, 2015 at 20:25

mr100

4,4382 gold badges29 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2416437 Over a year ago

Hi mr100, thank you for your answer. Your proposal fit my needs so I implements "logging and intercepting database operaitons". Futhermore, your sample about the extension is right too. Really thanks, I think effectively I was on the wrong way.

Collectives™ on Stack Overflow

Inherit from DbSet<TEntity> in Entity Framework Code first NullReference

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related