could not able to pass string values to javascript function

Question

When trying to pass String value to the javascript function , Uncaught ReferenceError is thrown on the browser console. Below is the sample code:

function mySampleTest(myId, comments){
    alert("myId " + myId);
    alert("comments : " + comments);
}

var myTest = function(value, rowIndex) {
    var myId = this.grid.getItem(rowIndex).MY_ID;
     var comments = this.grid.getItem(rowIndex).COMMENTS;
    return "<img src=<%=request.getContextPath()%>/images/image1.gif width=\"25\" height=\"25\" onClick=\"mySampleTest("+ myId +" , "+comments+")\">";
};

The JavaScript function mySampleTest is being called when the user clicks the image but it throws a JavaScript error when I pass the string comments to mySampleTest function. If I remove the comment parameters and just pass the myId to mySampleTest(..), it works fine. Please suggest how to pass string values to the JavaScript function. I tried the below also, but didn't work.

 return "<img src=<%=request.getContextPath()%>/images/image1.gif width=\"25\" height=\"25\" onClick=\"mySampleTest("+ myId +" , \'' + comments + '\')\">";

what is the exact error? What does browser source version look like? If this is in a js file none of your server code will be compiled. — charlietfl
– charlietfl, Commented Apr 10, 2015 at 18:34
Does the error tell you a specific line or part of the code that causes it? — 9Deuce
– 9Deuce, Commented Apr 10, 2015 at 18:35
can you try this? return "<img src=<%=request.getContextPath()%>/images/image1.gif width=\"25\" height=\"25\" onClick=\"mySampleTest('"+ myId +"' , '" + comments + "')\">"; — Sushil
– Sushil, Commented Apr 10, 2015 at 18:46
thanks @JDB. I believe his html is not getting rendered properly and hence the error. if he can just add a single quote before and end of the variable then it should work. — Sushil
– Sushil, Commented Apr 10, 2015 at 18:52

JDB · Accepted Answer · 2015-04-10 18:56:03Z

3

As a professor once told me, much of writing code involves "being the computer".

Consider your function's output for a moment and you should see the issue pretty quickly:

<img src=whatever/your/context/path/is/images/image1.gif
     width="25" height="25"
     onClick="mySampleTest(12345, this is a comment)">

Your javascript is invalid:

mySampleTest(12345, this is a comment)

It should be:

mySampleTest(12345, 'this is a comment') // <--- notice the quotes

Which would translate all the way back to:

return "<img src=\"<%=request.getContextPath()%>/images/image1.gif\" width=\"25\" height=\"25\" onClick=\"mySampleTest('"+ myId +"' , '"+comments+"')\">";

Not to mention your src attribute really needs quotes.

answered Apr 10, 2015 at 18:56

JDB

26.1k5 gold badges81 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

could not able to pass string values to javascript function

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related