C programming: Strings

Question

My problem is: Input name and print out in the order

Ex: input the name : Martin Luther King

result : King,Martin-Luther

But when i run this code it prints out : King,LutherMartin-Luther. Can you help show me the mistake?

#include<stdio.h>
#include<conio.h>
#include <string.h>
int main()
{
char name[100];
int i;
printf("input full name: "); gets(name);
char * c =&name[strlen(name)-1];
while (*(c)!=' ')
    c--;
printf("%s,",c);
*c= '\0';
char *d=&name;
while (*(d)!=' ')
    d++;
printf("%s",d);
*d='-';
printf("%s",name);
getch();
return 0;
}

Your first printf prints "King,", second printf prints "Luther". After that, you do not set *d to NULL, you set it to '-'. At that point, name becomes "Martin-Luther\0King\0". So the last printf prints "Martin-Luther". So, your second printf is unnecessary if you're converting "X Y Z" to "Z,X-Y". — holgac
– holgac, Commented Apr 12, 2015 at 14:14
the header file conio.h is not portable. suggest removing that header file and replacing getch() with getchar() — user3629249
– user3629249, Commented Apr 12, 2015 at 14:32
@user3629249 thank you :) i use both visual and code block, so when i use visual i have to use conio.h — DonDave
– DonDave, Commented Apr 12, 2015 at 14:38
in C, the name of an array devolves to the address of the array. So this line: 'char *d=&name;' should be: 'char *d=name;' — user3629249
– user3629249, Commented Apr 12, 2015 at 14:44

Spikatrix · Accepted Answer · 2015-04-12 14:40:38Z

1

printf("%s",d);

is the root of the problem as it results in the extra print of the middle name. Simply remove that line.

edited Apr 12, 2015 at 14:40

Spikatrix

20.3k7 gold badges44 silver badges85 bronze badges

answered Apr 12, 2015 at 14:35

user3629249

16.6k1 gold badge18 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

kostasgra · Accepted Answer · 2015-04-12 14:39:23Z

0

The string is "Martin Luther King"
You Display "King" first.
Then "Martin".
Then again "Martin-Luther".

Just remove the printf at line 17.

answered Apr 12, 2015 at 14:39

kostasgra

11 bronze badge

Collectives™ on Stack Overflow

C programming: Strings

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related