using $.getJSON in a loop to append to global variable

Question

I am writing a small script that takes an array of locations and geocodes them to add lat long to another object. I have it working so it geocodes and writes to the console flawlessly. How can I take that output and put it into a predefined variable outside of the function? I am not vary familiar with jquery and do not intend on using it anyplace else in the script.

Just started learning JavaScript this weekend so don't shoot me if Something else is messed up.

Thanks for any help!!

Also, I changed my Google API key so it isn't stolen.

      //test array of locations to geocode
var locationsToGeoCode = ["China: Shandong: Jinan",
    "China: Shandong: Jinan",
    "United States: Washington: La Conner",
    "United States: Texas: Dallas",
    "United States: California: Walnut"
    ];

//empty object to place geocoded places
var coordinates;

for (var i = 0; i < locationsToGeoCode.length; i += 1) {
  $.getJSON("https://maps.googleapis.com/maps/api/geocode/json?address=" + locationsToGeoCode[i] + "&key=MIzaSyCywKsD_50EI9rheDLyqPOUdUzi6s6u-q8", function (geocodeResult) {
        console.log(geocodeResult);
        });
    }

@BradChristie that would work if he wanted an array, but from the question I think he wanted an object — winhowes
– winhowes, Commented Apr 13, 2015 at 4:30
I guess I wasn't taking "empty object" as literally as I should have been. ;-) — Brad Christie
– Brad Christie, Commented Apr 13, 2015 at 4:31
I don't think there's a clear preference expressed for array vs. object. However, an array may be problematic when you have multiple async requests in-flight concurrently, with an object it's easier to avoid those kind sof problems by keying the responses properly. — aroth
– aroth, Commented Apr 13, 2015 at 4:34

winhowes · Accepted Answer · 2015-04-13 04:29:10Z

1

Modifying your code like such should work:

      //test array of locations to geocode
var locationsToGeoCode = ["China: Shandong: Jinan",
    "China: Shandong: Jinan",
    "United States: Washington: La Conner",
    "United States: Texas: Dallas",
    "United States: California: Walnut"
    ];

//empty object to place geocoded places
var coordinates = {};

function fetchGeoCode(location){
     $.getJSON("https://maps.googleapis.com/maps/api/geocode/json?address=" + location + "&key=MIzaSyCywKsD_50EI9rheDLyqPOUdUzi6s6u-q8", function (geocodeResult) {
        coordinates[location] = geocodeResult;
    });
}

for (var i = 0; i < locationsToGeoCode.length; i += 1) {
    fetchGeoCode(locationsToGeoCode[i]);
}

answered Apr 13, 2015 at 4:29

winhowes

8,1255 gold badges31 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

aroth Over a year ago

+1 as this also averts potential issues with firing multiple async requests in rapid succession, such as having results returned in an arbitrary order.

Collectives™ on Stack Overflow

using $.getJSON in a loop to append to global variable

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related