Reusable code for $http calls in angular

Question

In all of my controllers I notice I have the same code over and over again after posting data. See below. Is there someway I can just pass my service to some sort of common function and handle everything there.

//user submits via click
$scope.submit = function(val) {
            MyService.update(val).then(function(result) {
                if (result.Success) {
                    $state.reload();
                }
                else {
                    $state.go('^');
                }
            })
    }

Maybe turn this into just

$scope.submit = commonFn(MyService.update(val));

Any advice on the best way to avoid this redundant code would be great!

@OliverSalzburg its all the same code as far as doing state reload on success. so in another controller it would be identical but OtherService.update instead of MyService.update — atsituab
– atsituab, Commented Apr 13, 2015 at 20:42

David says Reinstate Monica · Accepted Answer · 2015-04-13 20:42:15Z

1

You could put the code into the Service and just pass the $state in:

MyService

updateAndReload = function(val, $state){
    update(val).then(function(result) {
       if (result.Success) {
         $state.reload();
       }
       else {
         $state.go('^');
       }
}

Controller

$scope.submit = MyService.updateAndReload(val, $state)

But this only works if it really is the exact same code every time. If there are more differences you probably just need to add more parameters.

answered Apr 13, 2015 at 20:42

David says Reinstate Monica

20.2k22 gold badges84 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cyril CHAPON · Accepted Answer · 2015-04-13 20:30:30Z

0

var commonFn = function(result) {
  if (result.Success) {
    $state.reload();
  }
  else {
    $state.go('^');
  }
}
MyService.update(val).then(commonFn);

answered Apr 13, 2015 at 20:30

Cyril CHAPON

3,7774 gold badges25 silver badges41 bronze badges

Collectives™ on Stack Overflow

Reusable code for $http calls in angular

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related