Python 3.4 Assign variable with variable

Question

This is a rather simple question;

I know that you can do:

foo = 1,
self.card1 = "This is card number %s." % (foo)

But I'm trying to assign that variable given by function to the name itself:

def card(foo):
  self.foo = foo
  self.usrCrdImg%self.foo = Image.open(self.crdStk[randint(1, 50)])
  self.usrCrdBg%self.foo = ImageTk.PhotoImage(usrCrdImg%self.foo)
  self.usrCrd%self.foo = tkinter.Label(root, image=usrCrdBg%self.foo)
  self.usrCrd%self.foo.image = self.usrCrdBg%self.foo

card(1)
#Should Execute like this
def card(1):
  self.usrCrdImg1 = Image.open(self.crdStk[randint(1, 50)])
  self.usrCrdBg1 = ImageTk.PhotoImage(usrCrdImg1)
  self.usrCrd1 = tkinter.Label(root, image=usrCrdBg1)
  self.usrCrd1.image = self.usrCrdBg1

Once I get the answer to this question, I'll have another question to ask.

Here's my Code

import tkinter
import winsound
from tkinter import *
from PIL import Image, ImageTk
from random import randint, randrange

class CardGame(tkinter.Frame):

  def __init__(self, root):

    tkinter.Frame.__init__(self, root)
    
    #define variables for cards
    self.crdImg = []
    usrStk = None
    cpuStk = None
    #define card images
    i = 1
    while i < 57:
      i = i + 1
      self.crdImg.append('img/cards/%s.png' % (i - 1))

    usrStk = self.crdImg[54]
    cpuStk = self.crdImg[55]

  def debug(card):
    self.card = card
    self.usrCrdImg%self.card = Image.open(self.crdStk[randint(1, 50)])
    self.usrCrdBg%self.card = ImageTk.PhotoImage(self.usrCrdImg%self.card)
    self.usrCrd%self.card = tkinter.Label(root, image=self.usrCrdBg%self.card)
    self.usrCrd%self.card.image = self.usrCrdBg%i
  def card(self):
  
    ###
    self.usrStk1 = self.crdImg[54]
    self.cpuStk1 = self.crdImg[55]
    ##
    self.usrCrdImg1 = Image.open(self.usrStk1)
    self.usrCrdBg1 = ImageTk.PhotoImage(self.usrCrdImg1)
    self.usrCrd1 = tkinter.Label(root, image=self.usrCrdBg1)
    self.usrCrd1.image = self.usrCrdBg1
    ##
    self.cpuCrdImg1 = Image.open(self.cpuStk1)
    self.cpuCrdBg1 = ImageTk.PhotoImage(self.cpuCrdImg1)
    self.cpuCrd1 = tkinter.Label(root, image=self.cpuCrdBg1)
    self.cpuCrd1.image = self.cpuCrdBg1

Don't try and do this. Use a list or a dictionary.

Daniel Roseman
– Daniel Roseman

2015-04-15 13:56:25 +00:00
Commented Apr 15, 2015 at 13:56 — Daniel Roseman
– Daniel Roseman, Commented Apr 15, 2015 at 13:56

Bryan Oakley · Accepted Answer · 2015-04-15 14:07:59Z

5

What you are trying to do is just about the worst way to solve your problem. Generally speaking, you shouldn't ever try to generate variable names on the fly.

The simplest solution is to use a dictionary. Something like this:

def debug(card):
    self.card = card
    self.usrCrd[self.card]["Img"] = ... 
    self.usrCrd[self.card]["Bg"] = ...

Though, a better solution is to make a "card" be an instance of a class. Then, you can store these properties as attributes of the class:

class Card(object):
    def __init__(self, background, image):
        self.bg = background
        self.img = image
        ...

...
self.usrCrd = Card(...)
self.cpuCrd = Card(...)

answered Apr 15, 2015 at 14:07

Bryan Oakley

389k53 gold badges582 silver badges739 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

The Gaming Hideout Over a year ago

This really helped me; I was over-complicating this. Thanks!

Ben Morris · Accepted Answer · 2015-04-16 15:23:03Z

1

If you Absolutely Must Create a variable, Eg. a Tkinter button, use something like:

vars = []
founditems = ['item', 'otheritem']
for i in founditems:
    vars.append(i)
for n in range(len(founditems)-1):
    exec('tkbutton' + vars[i] + '=' + 'Button(textvariable=tv' + vars[i] + ', command=lambda: buttoncommand(' + vars[i] + '))')

The basic format: exec(var + '=' + varvalue)

If you only need to define the variables name, just do exec('varname = ' + varvalue)

edited Apr 16, 2015 at 15:23

answered Apr 15, 2015 at 14:57

Ben Morris

6265 silver badges24 bronze badges

1 Comment

Ben Morris Over a year ago

@BryanOakley My View Exactly

Collectives™ on Stack Overflow

Python 3.4 Assign variable with variable

Here's my Code

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

Here's my Code

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related