Iterating and Deleting from json array

Question

I have an object and I want to remove the element from it.

Eg : My object is like as below

var DecisionObj = '{"Decision":[{"recid":"1183","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"662","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"752","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""}]}';

Suppose I want to delete row with recid = 662

Below is the code i tried

var DecisionObj = '{"Decision":[{"recid":"1183","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"662","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"752","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""}]}';
obj = JSON.parse(DecisionObj);
console.log("BEFORE==="+JSON.stringify(obj));
var ddcnt = obj.Decision.length;
var recval = 662;
for (e = 0; e < ddcnt; e++) 
{
     //var DRecVal = obj.Decision[e].recid;
     var DRecVal = obj.Decision[e].recid;
     if(recval == DRecVal)
     { 
       obj.Decision.splice(e,1);
     }
}
console.log("AFTER==="+JSON.stringify(obj));

But the above code gives me an error like TypeError: obj.Decision[e] is undefined on line 21.

How shall I solve this.Help appreciated!Thanks!

Use instead for(properties in obj.Decision) and access DRecVal by properties.recid — Mateusz Nowak
– Mateusz Nowak, Commented Apr 15, 2015 at 15:20

RhinoDevel · Accepted Answer · 2015-04-15 15:57:13Z

2

Just add a

break;

after the splice() call in the loop.

answered Apr 15, 2015 at 15:57

RhinoDevel

7121 gold badge12 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mukta Chourishi Over a year ago

Rhinodevil , You are a genius man!You solved my query in such a short line of code.Thanks a lot

Tomuke · Accepted Answer · 2015-04-15 15:22:52Z

1

'.length' is not zero indexed. Ammend your variable to the following:

var ddcnt = obj.Decision.length - 1;

answered Apr 15, 2015 at 15:22

Tomuke

8792 gold badges10 silver badges27 bronze badges

3 Comments

joshvito Over a year ago

you get undefined, because the loop is looking for a 4th item at index 3 in the array.

Tomuke Over a year ago

yes, becuase .length returns a one-indexed value and arrays are zero-indexed

ssube Over a year ago

length isn't indexed, as such; it's an absolute value (whether the array starts at 0 or 1, it still has N items).

RobertoNovelo · Accepted Answer · 2015-04-15 15:41:42Z

This works accepting the recid string:

var DecisionObj = '{"Decision":[{"recid":"1183","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"662","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"752","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""}]}';

var DecisionObj = JSON.parse(DecisionObj);


function removeByRecid(arr, recid) {
  for (var elem in arr) {
    if (arr.hasOwnProperty(elem)) {
      if((typeof arr[elem].recid !== 'undefined') && (arr[elem].recid == recid))
      {
        console.log(arr[elem]);
        var index = arr.indexOf(elem);
        arr.splice(index, 1);
      }
    }
  }
}


function removeRecid(obj, recid) {
  for (var key in obj) {
    if (obj.hasOwnProperty(key)) {
      if (Object.prototype.toString.call(obj[key]) === '[object Array]') {
        removeByRecid(obj[key], recid);
      }
    }
  }
}


console.log(DecisionObj);
removeRecid(DecisionObj, "1183");
console.log(DecisionObj);

score 0 · Accepted Answer · 2015-04-15 16:09:09Z

0

Try this

var DecisionObj = '{"Decision":[{"recid":"1183","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"662","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"752","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""}]}';
obj = JSON.parse(DecisionObj);
console.log("BEFORE==="+JSON.stringify(obj));
var ddcnt = obj.Decision.length;
var recval = 662;
for (e = 0; e < ddcnt; e++) 
{
     //var DRecVal = obj.Decision[e].recid;
     var DRecVal = obj.Decision[e].recid;
     if(recval == DRecVal)
     { 
       obj.Decision.splice(e,1);
       break;
     }
}
console.log("AFTER==="+JSON.stringify(obj));

UPDATE :

    function removeID(recid){       
        var DecisionObj = '{"Decision":[{"recid":"1183","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"662","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""},{"recid":"752","reason":"Approved but with different Funding Amount","decision":"Approved","approvalamt":"","comment":""}]}';
        obj = JSON.parse(DecisionObj);
        console.log("BEFORE==="+JSON.stringify(obj));
        var ddcnt = obj.Decision.length;
        for (e = 0; e < ddcnt; e++) {
            var DRecVal = obj.Decision[e].recid;
            if(recid == DRecVal){ 
                obj.Decision.splice(e,1);
            }
        }
        console.log("AFTER==="+JSON.stringify(obj));
    }


removeID(752);

edited Apr 15, 2015 at 16:09

answered Apr 15, 2015 at 15:24

user1846747

8 Comments

Mukta Chourishi Over a year ago

Thanks Divakar.I tried this code but then I am not able to remove the last element here.Here the last element is 752.Any suggestion?

user1846747 Over a year ago

@MuktaChourishi Are you not trying to remove the last element? Your question says that you need to remove a row with recid 662. The above code removes row with recid 662 as stated in your question.

Mukta Chourishi Over a year ago

That's an example.I would get recid dynamically and it may happen that 752 is to be deleted.

user1846747 Over a year ago

@MuktaChourishi then you can put this into a function and pass the recid to be deleted as a parameter. Check my updated answer.

Mukta Chourishi Over a year ago

Divakar , Code is not working for the last element in array for others it does.

|

Collectives™ on Stack Overflow

Iterating and Deleting from json array

4 Answers 4

1 Comment

3 Comments

Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

3 Comments

Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related