SqlReader object does not read

Question

I am using SqlReader object(reader) to assign a string value from Sql-server database to an image's ImageUrl, but the ImageUrl is always empty while the reader object doesn't satisfy the while loop condition when debugging.

protected void Button3_Click(object sender, EventArgs e)
    {
        string query = "select profilePicture from Users where username = '@username'";
        command = new SqlCommand(query, connection);
        command.Connection = connection;
        command.Parameters.Add("@username", SqlDbType.VarChar).Value = User.Identity.Name;
        connection.Open();
        using (SqlDataReader reader = command.ExecuteReader())
        {
            while (reader.Read())
            {
                ProfilePhotoButton.ImageUrl = reader[0].ToString();
            }
        }
        connection.Close();
    }

Habib · Accepted Answer · 2015-04-16 18:14:29Z

3

You have single quotes enclosing your parameter. Remove that.

 string query = "select profilePicture from Users where username = '@username'";
                                                                  //HERE

It should be:

 string query = "select profilePicture from Users where username = @username";

Enclosing value in single quotes would be take care by the parameter type you have specified while adding parameters to your command.

As a side note, enclose your Command and Connection object in using statement as well to ensure disposal of resources.

answered Apr 16, 2015 at 18:14

Habib

224k30 gold badges420 silver badges446 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

SqlReader object does not read

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related