Type Error in javascript: Cannot read Property of undefined

Question

I have a javascript function that loos like this :

var usedNums= new Array(76);
function setSquare(thisSquare)
{

    var currSquare = "square"+ thisSquare;
    var colPlace =  new Array(0,1,2,3,4,0,1,2,3,4,0,1,2,3,4,0,1,2,3,4,0,1,2,3,4);
    var colBasis = colPlace[thisSquare] * 15;

    var newNum;
    do{
      newNum = colBasis + getNewNum() + 1;

    }while(usedNums[newNum]); //UnCaught TypeError here

    usedNums[newNum] = true;
    document.getElementById(currSquare).innerHTML = newNum;
}

The error says:

Can not read property '5' of undefined.

I have checked using console.log statement and all the variables above are getting expected values .

I understand what Type Error is but not sure where is it breaking.

**Edit:**Here is the complete Script:

window.onload = new newCard;
var usedNums= new Array(76);

function newCard()
{
  if(document.getElementById){
      for(var i =0; i<24;i++)
      { 
          console.log("Value of I is " + i);
          setSquare(i);

      }
  }else{

   alert("Sorry, your browser does not support this script");
  }
}

function setSquare(thisSquare)
{
    console.log("thissquare" + thisSquare);
    var currSquare = "square"+ thisSquare;
    console.log("currsquare" + currSquare);
    var colPlace =  new Array(0,1,2,3,4,0,1,2,3,4,0,1,2,3,4,0,1,2,3,4,0,1,2,3,4);
    console.log("colplace" + colPlace);
    var colBasis = colPlace[thisSquare] * 15;
    console.log("colbasis"+ colBasis);
    var newNum;
    do{
      newNum = colBasis + getNewNum() + 1;
      console.log("new nUM" + newNum);
    }while(usedNums[newNum]);

    usedNums[newNum] = true;
    document.getElementById(currSquare).innerHTML = newNum;
}

function getNewNum()
{
var a = Math.floor(Math.random() * 15);
console.log("random number" + a);
return a;
}

where is the definition of usedNums, because it seems that it's not defined? — Vasilev
– Vasilev, Commented Apr 17, 2015 at 14:50
Uncaught ReferenceError: getNewNum is not defined — Please make sure your provide code in the question that actually demonstrates the problem: sscce.org — Quentin
– Quentin, Commented Apr 17, 2015 at 14:57
@sscce.org: Error says UnCaught Type Error only.Added getNewNum definition in the question. — simar kaur
– simar kaur, Commented Apr 17, 2015 at 14:59
Please provide the code for getNewNum(). Providing an example of how you're using this function would be helpful as well. — Nick
– Nick, Commented Apr 17, 2015 at 14:59

Quentin · Accepted Answer · 2015-04-17 15:07:40Z

1

This line:

window.onload = new newCard;

is:

Invoking newCard as a constructor (which it isn't)
Assigning the object created from it to onload

Since you are invoking newCard there, it runs before you reach the next line:

var usedNums= new Array(76);

So usedNums is undefined when you try to read from it.

You need to assign the newCard function as your load handler. So don't invoke it:

window.onload = newCard;

answered Apr 17, 2015 at 15:07

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

simar kaur Over a year ago

@Quertin: That helped.I am pretty new to javascript. Do you mind commenting on how do we distinguish other functions form constructor in javascript?

Collectives™ on Stack Overflow

Type Error in javascript: Cannot read Property of undefined

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related