Input Onclick button Function

Question

Hello Guys I have a textbox which if the value inside the textbox is zero. It will pop up alert. but no alert is happening.

<input type="text" id="numbers" value= "0" >



                  <th style="width:5%;"><h4><input id="submitbutton" onclick="clicked();" class="btn btn-success" type="submit" name="<?php if($final==true){ echo "viewsummary" ;}else{ echo "next";} ?>" value="<?php if($final==true){ echo "View Summary" ;}else{ echo "Submit";} ?>" class="subbtn"/>

                    <script language="javascript">

                    document.getElementById('submitbutton')
                    function clicked(){
                        if (document.getElementById('numbers') == 0) {
                        window.alert("Please Play the Audio First");
                    }

                    }                        
                    </script>

I dont know whats the error If I look at the code for me its just fine? whats wrong? Thank you guys :")

You might be encountering script error, look at this line which is not terminated properly or not written correctly. document.getElementById('submitbutton') — Sai G
– Sai G, Commented Apr 17, 2015 at 15:30

NaijaProgrammer · Accepted Answer · 2015-04-17 15:19:44Z

1

Use this:

function clicked()
{
   if (document.getElementById('numbers') && document.getElementById('numbers').value == 0)
   {
     window.alert("Please Play the Audio First");
   }
}

answered Apr 17, 2015 at 15:19

NaijaProgrammer

2,9202 gold badges27 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

NaijaProgrammer Over a year ago

@Nathaniel, if it works for you, mark it as the accepted answer so someone else facing similar problem can benefit from it.

Nathaniel Over a year ago

Yes sir u just wait 5 min

CodingIntrigue · Accepted Answer · 2015-04-17 15:17:27Z

0

You need to check the value, not the element:

document.getElementById('numbers').value == "0"

Also, value will be a string and not a number. Full code:

//document.getElementById('submitbutton')
//^^ this does nothing

function clicked() {
    if (document.getElementById('numbers').value === "0") {
        window.alert("Please Play the Audio First");
    }

}

Don't forget, inside a form this may trigger the form action. "Please Play the Audio First" indicates that you don't want the form to submit if that if statement is hit, so you should return a value to stop that happening:

function clicked() {
    if (document.getElementById('numbers').value === "0") {
        window.alert("Please Play the Audio First");
    }
    return false;
}

HTML:

<input id="submitbutton" onclick="return clicked();" .... />

edited Apr 17, 2015 at 15:17

answered Apr 17, 2015 at 15:14

CodingIntrigue

79k32 gold badges176 silver badges178 bronze badges

2 Comments

Nathaniel Over a year ago

Its still not working sir huhuhu no alert happens :(

CodingIntrigue Over a year ago

Check here: jsfiddle.net/sdzg2hr0 - You'd need to see why yours differs from this working version

Collectives™ on Stack Overflow

Input Onclick button Function

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related