Writing a Nested shell script- Unable to pass argument

Question

I am trying to create a shell script using another script. Following is the code.

#!/bin/bash
count=$#
cat << EOF > /tmp/kill_loop.sh 
#!/bin/bash

while true;
do
    for i in "$@"
    do
       echo $i
    done

done 
EOF

When I see kill_loop.sh , "$i" is empty.

#!/bin/bash
while true;
do
    for i in "one two three"
    do
       echo

    done
done

I want "$i" to be printed as such in kill_loop.sh file so that if i execute kill_loop.sh, it echoes the value 'one','two' and 'three'

this looks like an exercise in "here"-file syntax. and not a very productive one at that. here's an alternative exercise: write a function "foreach" which executes it's first argument on the remainder. then this whole exercise becomes: "foreach echo one two three" not to mention in the original code, even with correct syntax, the while true; do ... never terminates?! — Marty McGowan
– Marty McGowan, Commented Apr 20, 2015 at 16:52
or if this was an exercise in killing a task run in the background, then you don't need a "here"-file to create a 'forever' loop?! conflating two learning points in one exercise is never a useful approach. pardon me if i'm incorrectly assuming this is an exercise — Marty McGowan
– Marty McGowan, Commented Apr 20, 2015 at 16:57

Moldova · Accepted Answer · 2015-04-20 14:35:51Z

3

Your "outer" shell script is interpreting $i as if it were one of its own variables, which isn't set, thus it evaluates to nothing. Try escaping the $ so the outer shell doesn't expand it:

echo \$i

answered Apr 20, 2015 at 14:35

Moldova

1,66111 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user4453924 Over a year ago

Or put it in single quotes

chepner Over a year ago

Single quotes won't help. The $ is effectively inside double quotes as part of the here document.

Marty McGowan · Accepted Answer · 2015-04-20 17:00:35Z

0

here is the "foreach" function:

function foreach
{ 
    typeset cmd=$1;
    shift;
    for arg in "$@";
    do
        $cmd $arg;
    done
}

edited Apr 20, 2015 at 17:00

answered Apr 20, 2015 at 16:41

Marty McGowan

3662 silver badges10 bronze badges

3 Comments

Charles Duffy Over a year ago

What's the point of quoting "$@" if you aren't going to quote $arg?

Charles Duffy Over a year ago

Leaving $cmd unquoted is also an interesting decision; depending on the desired semantics around how a cmd that consists of multiple words (or includes shell indirections or expansions) should be treated, it might be correct to quote cmd's expansion; to use read -a to read it into an array and perform a quoted expansion of that array; or to go all the way and use eval (allowing even dangerous shell constructs to be used).

Charles Duffy Over a year ago

Also, why the function keyword? That breaks POSIX sh compatibility... and to what end?

Collectives™ on Stack Overflow

Writing a Nested shell script- Unable to pass argument

2 Answers 2

2 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related