php and mysql syntax issues using update statements

Question

i am trying to figure out the syntax problem in my query the block of code goes like this:

$updatequery = "update patient_dim set dentist_id = $dentist_id where".
                "patient_id = $patient_id";
$queryResult = mysql_query($updatequery,$con);

if(!$queryResul){
      trigger_error("insert error" . mysql_error());
}

mysql_close($con);

then the error goes like this:
Notice: inssert errorYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '\"1" where patient_id = 4'

i suspect incorrect syntax in the $updatequery statement

for further information value of the $patient_id = 1 while the value of the $dentist_id = 4, i have tried all of your approaches still the same error. anyway thanks your helping

Do not use deprecated mysql_* API. Use mysqli_* or PDO and learn about prepared statements. — Jens
– Jens, Commented Apr 22, 2015 at 8:51
To troubleshoot an error like this normally you would output your query to a string and try to execute it manually. Doing this would highlight, as @AbhikChakraborty noted, you are missing a space. — Chris Pickford
– Chris Pickford, Commented Apr 22, 2015 at 9:00

Narendrasingh Sisodia · Accepted Answer · 2015-04-22 08:49:32Z

1

Your query needs space after where

$updatequery = "update patient_dim set dentist_id = $dentist_id where patient_id = $patient_id";

answered Apr 22, 2015 at 8:49

Narendrasingh Sisodia

21.4k6 gold badges51 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

John Nifled T. Ebora Over a year ago

still does not work, same error with the syntax, all values of the variable is correct

Narendrasingh Sisodia Over a year ago

Can you update your question with echoed value of query

Danyal Sandeelo · Accepted Answer · 2015-04-22 08:49:47Z

1

$updatequery = "update patient_dim set dentist_id = $dentist_id where".
            " patient_id = $patient_id";

you forgot to add space after WHERE clause

answered Apr 22, 2015 at 8:49

Danyal Sandeelo

12.4k10 gold badges57 silver badges90 bronze badges

1 Comment

developer__c Over a year ago

I would go as far to say you might as well remove the concatenation and just have one, one line, query string ("update patient_dim set dentist_id = $dentist_id where patient_id = $patient_id")

Pravat Kumar Sahoo · Accepted Answer · 2015-04-22 09:22:56Z

0

After WHERE Clause there must be a blank space before the condition. Use as follows.

<?php
    $updatequery = "update patient_dim set dentist_id = ".$dentist_id ." where patient_id = ".$patient_id;
    $queryResult = mysql_query($updatequery);
    if(!$queryResult){
         die("insert error" . mysql_error());
    }

    mysql_close($con);
?>

edited Apr 22, 2015 at 9:22

answered Apr 22, 2015 at 8:53

Pravat Kumar Sahoo

3032 silver badges9 bronze badges

3 Comments

John Nifled T. Ebora Over a year ago

i tred your approach and still the same error, and all variables has the correct value

Pravat Kumar Sahoo Over a year ago

echo $updatequery and try to execute the query in SQL Editor(PhpMyadmin),It will help you to catch the error.Can you please change the variables in if statement from $queryResul to $queryResult (It is a typo Mistake).I am editing the query,Please try again.

John Nifled T. Ebora Over a year ago

i already figure out the typo , there's a mistyped / in the other parts of the code. anyway thank you helping out

Collectives™ on Stack Overflow

php and mysql syntax issues using update statements

3 Answers 3

2 Comments

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related