Uploading document in NodeJs using Fs module : Error: write after end

Question

I have been trying to upload a document using the following code.

I did googled and could not find any solution as yet.

app.post('/documents', function (req, res) {

    var document = {};

    var fstream = null;

    // populate fields
    form.on("field", function (name, value) {
        document[name] = value ;

    });

    form.on("part", function (part) {

        if (!part.filename) {
            return;
        }

        var path = __dirname + '/files/' + part.filename;

         fstream = app.npm.fs.createWriteStream(path);

        document.type = part.headers["content-type"]
        document.name = part.filename;
        document.size = part.byteCount;
        document.path = path;

        fstream.on("close", function () {
            db.sequelize.models.Document.create(document).then(function (newDocument) {
                    res.send(newDocument)
                    res.end();
                },
                function (error) {
                    res.send(error);
                });
        });
        part.pipe(fstream);

    });

    form.on("close", function (data) {

        fstream.end();
        fstream = null;

    });

    form.parse(req);
});

NOTE: I am using fs module. https://nodejs.org/api/fs.html

The first image works ok. but when I try to upload an another image, it throws an exception:

events.js:72 throw er; // Unhandled 'error' event ^

Error: write after end at writeAfterEnd (_stream_writable.js:132:12) at Form.Writable.write (_stream_writable.js:180:5) at write (_stream_readable.js:601:24) at flow (_stream_readable.js:610:7) at IncomingMessage.pipeOnReadable (_stream_readable.js:642:5) at IncomingMessage.emit (events.js:92:17) at emitReadable_ (_stream_readable.js:426:10) at emitReadable (_stream_readable.js:422:5) at readableAddChunk (_stream_readable.js:165:9) at IncomingMessage.Readable.push (_stream_readable.js:127:10)

@robertklep completely agreed! I will further refactor on this.... however I could not find any other way to set the multi part stream with form data. — codebased
– codebased, Commented Apr 24, 2015 at 12:44

codebased · Accepted Answer · 2015-04-24 11:42:23Z

7

Found the solution.

var form = new app.npm.multiparty.Form();

This was defined at global level. Where as for every new request I should be creating a new instance of the form because stream is off in the previous call so I should create a new instance by getting latest contents.

The solution looks likes:

app.post('/documents', function (req, res) {

var document = {};

var form = new app.npm.multiparty.Form();

var fstream = null;

...

And the rest is same.

answered Apr 24, 2015 at 11:42

codebased

7,07311 gold badges57 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Shiprack Over a year ago

Yeah, I made the same mistake. Looking more clearly at the documentation, it clearly shows that a multiparty.Form is instantiated in every call to the callback passed on to http.createServer (every request). And I looked over that too, ending up searching for "Multiparty Error: write after end", which brought me to your question.

Collectives™ on Stack Overflow

Uploading document in NodeJs using Fs module : Error: write after end

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related