Java 8 : Map Lambda expression

Question

I have a Map<String, List<Object>> multiFieldMap and I need to itereate over its value set and add the value to multiFieldsList as below

public List<Object> fetchMultiFieldsList() {
    List<Object> multiFieldsList = new ArrayList<Object>();
    for (Entry<String, List<Object>> entry : multiFieldMap.entrySet()) {
        String entityName = entry.getKey();
        List<Object> ids = entry.getValue();
        for (Object id : ids) {
            Object entity = queryService.query(entityName, queryService.property("id").eq(id));
            multiFieldsList.add(entity);
        }
    }
    return multiFieldsList;
}

Am wondering can this method be simplified further?

Eran · Accepted Answer · 2015-04-27 06:27:58Z

6

You can use the Streams API :

List<Object> multiFieldsList = 
    multiFieldMap.entrySet()
                 .stream()
                 .flatMap(e -> e.getValue()
                                .stream()
                                .map(o -> queryService.query(e.getKey(), queryService.property("id").eq(o))))
                 .collect(Collectors.toList());

edited Apr 27, 2015 at 6:27

answered Apr 27, 2015 at 6:26

Eran

395k57 gold badges726 silver badges793 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

fge Over a year ago

This is typically a case where I personally think that a full stream solution is actually less readable than a "good old" foreach loop :p

fge · Accepted Answer · 2015-04-27 06:26:05Z

2

You can indeed use a stream to simplify you inner loop.

You can replace:

List<Object> ids = entry.getValue();
for (Object id : ids) {
    Object entity = queryService.query(entityName, queryService.property("id").eq(id));
    multiFieldsList.add(entity);
}

with:

entry.getValue().map(
    id -> queryService.query(entityName, queryService.property("id").eq(id))
).forEach(multiFieldsList::add);

But you don't really gain much from that. Your choice...

See @Eran's answer for a "full stream" solution.

answered Apr 27, 2015 at 6:26

fge

122k35 gold badges266 silver badges340 bronze badges

1 Comment

Holger Over a year ago

Code simplification does not always need Stream API use…

Holger · Accepted Answer · 2015-04-27 09:25:10Z

2

You can simplify it like this:

public List<Object> fetchMultiFieldsList() {
    List<Object> multiFieldsList = new ArrayList<>();
    multiFieldMap.forEach( (entityName, ids ) ->
        ids.forEach( id -> multiFieldsList.add(
            queryService.query(entityName, queryService.property("id").eq(id)))
        )
    );
    return multiFieldsList;
}

Unless you want to use the Stream API, the method Map.forEach might be the biggest win regarding code simplification as you don’t need to deal with Map.Entry and its generic signature anymore…

answered Apr 27, 2015 at 9:25

Holger

301k43 gold badges481 silver badges827 bronze badges

Collectives™ on Stack Overflow

Java 8 : Map Lambda expression

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related