objective C filling array with custom class pointers

Question

favorites = [[NSMutableArray alloc] init];

for (int i=0; i<9; i++) {

  [favorites addObject:[[[Favorite alloc] constructUnknown] autorelease]];



 }

i'm getting:

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[Favorite size]: unrecognized selector sent to instance 0x380d9c0'

why?

Favorite is my custom class, favorites an array containing 9 instances of my custom class

edit:

Favorite.h:

-(Favorite*)constructUnknown;

Favorite.m:

 - (Favorite*)constructUnknown{


self=[super init];

if (self) {
    image=[UIImage imageNamed:@"unknown.png"];
}

return self;

}

COMPLETE FAVORITES.h

@interface Favorite : NSObject {

NSString *identity;
bool ready;

UIImage *image;
NSURL *telephone;


}

@property (nonatomic,retain) UIImage *image;
@property (nonatomic,retain) NSURL *telephone;
@property (nonatomic,retain) NSString *identity;

//passare unknown al nome per costrutire un oggetto unknown.
-(Favorite*)constructWithID:(NSString*)name withPhoto:(UIImage*)photo andNumber:(NSString*)number;

-(Favorite*)constructUnknown;
-(NSURL*) convertToUrl:(NSString*)phone;
- (UIImage*) getImage;

@end

Show us Favorite.h? I'm curious whether you've properly subclassed NSObject. — Dan Ray
– Dan Ray, Commented Jun 7, 2010 at 15:13

kennytm · Accepted Answer · 2010-06-07 15:48:55Z

2

The exception is likely because your image is not retained. Try

image = [[UIImage imageNamed:@"unknown.png"] retain];

BTW, initializers should be named as -initXXX and return an id by convention. e.g.

 -(id)initWithUnknown{ ... }

answered Jun 7, 2010 at 15:48

kennytm

526k110 gold badges1.1k silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Jon Shier Over a year ago

Doesn't need to retain the UIImage, as the class method imageNamed: returns an autoreleased object, as per the ownership guidelines. Good point on the initializer naming though.

mipadi Over a year ago

@jshier: If the object is autoreleased, and you want to keep it around, then you do need to retain it.

Jon Shier Over a year ago

Ah, true. My bad. Does indeed seem this would be the problem.

Andrea Over a year ago

yeah.that works.thank you.retaining an object means it stays in memory and not be released out of his scope?

kennytm Over a year ago

@palominoz: It's better to think in terms of ownership. -retain means "from now on this object is the owner of the image". Remember to -release it in the Favorite's -dealloc as it is no longer the owner of the image.

|

Khattab · Accepted Answer · 2011-03-16 00:53:58Z

0

Just in case someone reads this and still doesn't reach a solution, my problem was a little different I declared the object as:

@class LoginViewController;

@interface LoginViewDelegate : NSObject <UIApplicationDelegate> {

}

....

@property (nonatomic, retain) AppConfiguration *CurrentAppConfig;

....

@End

And when I was calling it:

[[self.CurrentAppConfig alloc] init];

I was getting the same error, all I had to do was use the synthesize keyword:

@implementation LoginViewDelegate

....

@synthesize CurrentAppConfig;

answered Mar 16, 2011 at 0:53

Khattab

7371 gold badge10 silver badges20 bronze badges

Collectives™ on Stack Overflow

objective C filling array with custom class pointers

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related