Modifying integral values

Question

I am taking a basic introductory class to C. I got the overall program to function, but it is not producing the required output as it should.

The task is to write a program that asks the user for an integer value and to modify the input so that the 1s and 100s place will have the same digit, whatever is the larger value.

For example:

1234 will be modified to 1434

1969 will be modified to 1969

2025 will be modified to 2525

For some reason, instead of taking the larger value of the 1s and 100s place, the program chooses the smaller value to modify the user input.

1234 -> 1232

2025 -> 2020

1962 -> 1262

Any hints or ideas on what might be wrong?

#include <stdio.h>
int main() {

    int myValue;
    int tmp;
    int oneDigit;
    int hundredDigit;
    int larger;
    int smaller;
    int factor;

    printf("\nEnter an int: ");
    scanf("%d", &myValue);

    // Getting absolute value
    tmp = (myValue < 0) ? -myValue : myValue;

    // Extracting digits
    oneDigit = tmp % 10;
    hundredDigit = (tmp / 100) % 10;

    // Grabbing larger and smaller integer
    larger = (oneDigit > hundredDigit) ? oneDigit : hundredDigit;
    smaller = (oneDigit > hundredDigit) ? hundredDigit : oneDigit;

    // Checking what to factor by
    factor = (oneDigit > hundredDigit) ? 1 : 100;

    // New modified digit
    tmp = tmp - (larger - smaller) * factor;

    printf("\nThe modified value of %d is %d\n", myValue, tmp);

    return 0;

}

CinCout · Accepted Answer · 2015-04-28 05:06:01Z

1

The line of code:

// New modified digit
tmp = tmp - (larger - smaller) * factor;

doesn't make any sense.

In either case (oneDigit is larger or hundredDigit is larger), you need to add some value to tmp, and not subtract.

Also, you have calculated the factor as reverse. It must be:

factor = (oneDigit > hundredDigit) ? 100 : 1;

answered Apr 28, 2015 at 5:06

CinCout

9,62916 gold badges55 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

R Sahu · Accepted Answer · 2015-04-28 05:11:05Z

1

You need to reverse the factor in this statement.

factor = (oneDigit > hundredDigit) ? 1 : 100;

Use

factor = (oneDigit > hundredDigit) ? 100 : 1;

You need to add (larger - smaller) * factor; to tmp, not subtract.

Instead of:

tmp = tmp - (larger - smaller) * factor;

use:

tmp = tmp + (larger - smaller) * factor;

edited Apr 28, 2015 at 5:11

answered Apr 28, 2015 at 5:05

R Sahu

207k15 gold badges168 silver badges291 bronze badges

1 Comment

Abortion Survivor Over a year ago

Thank you for your quick response. I've tried your method, but when I input 1234, it gives me 1236, which is not the expected output However, when I enter in 1232, it returns 1232, which is the expected output. Do you know why this is happening? Even after modifying the two sections of code that you pointed out was incorrect. Thank you again.

Nerdy · Accepted Answer · 2015-04-28 05:13:57Z

1

change this:

factor = (oneDigit > hundredDigit) ? 1 : 100;

to

factor = (oneDigit > hundredDigit) ? 100 : 1;

and also change

 tmp = tmp -(larger - smaller) * factor;

to

  tmp = tmp +(larger - smaller) * factor;

answered Apr 28, 2015 at 5:13

Nerdy

1,1092 gold badges13 silver badges28 bronze badges

Collectives™ on Stack Overflow

Modifying integral values

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related