php map digit to string

Question

I am trying to write a program in php which first prompts a user for a string. once they enter a string it is supposed to give the equivalent digits if it were on a phone. eg ABC(2) , DEF(3) , GHI(4) , JKL(5) , MNO(6) , PQRS(7) , TUV(8) , WXYZ(9). Im using a for loop and nested if statements but i am not getting the correct output. Am I going about this the right way? my code is below

<?php

$str = $_POST['usersString'];

$len = strlen($str);

for($i=0; $i<$len-1; $i++){
    if($i="a" || $i="b" || $i="c"){
        echo "1";
    }

    if($i="d" || $i="e" || $i="f"){
        echo "2";
    }

    if($i="g" || $i="h" || $i="i"){
        echo "3";
    }
}    

?>
<form action="task17.php" method="POST">
Enter a string <input type="text" name="usersString" />
<input type="submit" value="enter" />
</form>

you have checked the for loop count against a string. it should be your string's particular value. — gecco
– gecco, Commented Apr 30, 2015 at 5:24

gecco · Accepted Answer · 2015-04-30 05:35:33Z

2

<?php

$str = $_POST['usersString'];

$len = strlen($str);

for($i=0; $i<$len; $i++){

   if($str[$i]=="a" || $str[$i]=="b" || $str[$i]=="c"){
    echo "1";

   }else if($str[$i]=="d" || $str[$i]=="e" || $str[$i]=="f"){
    echo "2";

   }else if($str[$i]=="g" || $str[$i]=="h" || $str[$i]=="i"){
    echo "3";
   }
}    

?>

your condition is wrong $i="a" It should be $str[$i]=="a"

edited Apr 30, 2015 at 5:35

answered Apr 30, 2015 at 5:22

gecco

2815 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Devon Bessemer Over a year ago

+1 for beating me to the first point about the offset. Still contains the issue with excluding the last character though. I'd modify it to exclude the -1 in the for loop.

Devon Bessemer · Accepted Answer · 2015-04-30 05:39:02Z

2

$i isn't going to be a letter in your loop, it's going to be an integer. What you want is to use $i as the offset of $str like $str[$i]. So with 'abc' $str[0] will be 'a'.

I would personally use an array for this to store the values:

$len = strlen($str);
$array = [ 'a' => 1, 'b' => 1, 'c' => 1, 'd' => 2, 'e' => 2, 'f' => 2 ];
// and so on...

for($i=0; $i<$len; $i++){
  echo $array[ $str[$i] ];
}

Note that I also used $i<$len rather than $i<$len-1. I don't think you want to use less than with -1. This would lead you to exclude the last character.

edited Apr 30, 2015 at 5:39

answered Apr 30, 2015 at 5:23

Devon Bessemer

35.6k10 gold badges77 silver badges102 bronze badges

1 Comment

Let me see Over a year ago

I didn't check the answer has already been posted. I got delayed due to the formatting issue i faced when writing answer.

Let me see · Accepted Answer · 2015-04-30 05:25:38Z

1

Use $str[$i] instead of $i in your If conditions like

if($str[$i]=="a" || $str[$i]=="b" || $str[$i]=="c"){ echo "1"; }
change your for loop to
```
for($i=0; $i < $len; $i++)
{   
}
```

answered Apr 30, 2015 at 5:25

Let me see

5,0949 gold badges40 silver badges49 bronze badges

1 Comment

Devon Bessemer Over a year ago

Unless you're adding to an answer, what's the point of posting the same stuff?

Sanjay Kumar N S · Accepted Answer · 2015-04-30 05:26:03Z

0

$str = "ADFJ";
$digitArr = array('abc', 'def', 'ghi', 'jkl', 'mno', 'pqrs', 'tuv', 'wxyz');
$strlne= strlen($str);
$digCount = count($digitArr);
for ($i = 0; $i < $strlne; $i++) {
    $j = 0;
    while ($j < $digCount) {
        if (stripos($digitArr[$j], $str[$i]) !== false) {
            $output[] = $j+1;
            break;
        }
        $j++;
    }
}
print_r($output);

answered Apr 30, 2015 at 5:26

Sanjay Kumar N S

4,7595 gold badges25 silver badges41 bronze badges

Collectives™ on Stack Overflow

php map digit to string

4 Answers 4

1 Comment

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related