.NET MVC Return to View from controller without model

Question

I have a controller with two methods:

Index(), that loads the model with data from DB.
GetFile(), that returns a file for the user to download.

If GetFile() fails, I want to return to the view, with an errormessage. I am NOT sending the model from the View to the controller-method GetFile().

My problem is:

If I want to return to the view from GetFile(), I will have to initialize the model and call the DB for the data. In my eyes, this is a waste of resources and should be avoided.

My question: is there a way to return to the View, without initializing the model again (call DB)

You can redirect to another view which may be used only for showing errors, — Mairaj Ahmad
– Mairaj Ahmad, Commented May 4, 2015 at 8:00

py3r3str · Accepted Answer · 2015-05-04 08:14:46Z

4

You can specify View name in View() method:

...
if(error)
{
     return View("Error");
}
return View(model);
...

In this case you have to have Error.cshtml file in controller View folder or in Share view folder. In tahat view you don't need to define model.

You can also use TempData to send error message to controller after redirect:

...
if(error)
{
     TempData["ErrorMessage"] = "Error";
     return Redirect("Index");
}
return View(model);
...

Then in Index or Layout view:

...
<div class="error">@TempData["ErrorMessage"]</div>
...

If you want render same view but without model you have to check if model isn't null before you use model.

...
if(Model != null)
{
     //---display model
}
else
{
     <div>Error message</div>
}
...

edited May 4, 2015 at 8:14

answered May 4, 2015 at 8:03

py3r3str

1,87919 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

TorK Over a year ago

yes that is possible, but I want to return to the same view but adding errormessages.

user4410678 Over a year ago

I would like to add that you can supply the error message as the viewmodel as the second parameter like this: return View("Error", "Something went wrong...");.

TorK Over a year ago

It works. But I wanted to know if it was possible to return to the view with the model without getting the data from DB again (I hoped it was saved in memory or something). Looks like this is not possible without sending the model from the view to the cotroller

Community · Accepted Answer · 2017-05-23 12:22:13Z

1

If I redirect to Index(), my errormessage dissapear.

That's why you should use TempData: Difference Between ViewData and TempData?

In your controller:

TempData["ImportError"] = "Some error string";
return RedirectToAction("Index");

In your Index view:

@TempData["ImportError"]

edited May 23, 2017 at 12:22

CommunityBot

11 silver badge

answered May 4, 2015 at 8:20

CodeCaster

153k24 gold badges237 silver badges287 bronze badges

10 Comments

clement Over a year ago

I think he don't want to load Index (and call DB) when there is error

CodeCaster Over a year ago

@clement no, OP says: "If I redirect to Index(), my errormessage dissapear. If I want to return to the view from GetFile(), I will have to initialize the model and call the DB for the data. " OP doesn't want to show GetFile() again.

clement Over a year ago

He also said I want to return to the same view but adding errormessages.

CodeCaster Over a year ago

And that's when TempData comes in handy if you don't want to alter or wrap your model.

clement Over a year ago

if he just wants to host one errormessage it does the trick, yes, but it looks like he wants to host more than one string... show the errormessages so multiple tempdata could be great, or one object as I mentionned

|

clement · Accepted Answer · 2015-05-04 08:31:19Z

0

The cleanest solution for me is to create your custom object that host all errors. With that object returned to the View, you can display as you want errors by using List and/or one errormessage (a understandable text for end-users for instance). This is a Container that has multiple fields that you can maybe edit to fill your needs:

public class Container<T>
    {
        private List<Error> _errors;
        private string _errorMessage;
        private bool _hasErrors;
        public T Value { get; set; }

        public bool HasErrors
        {
            get
            {
                if (!_hasErrors && !string.IsNullOrEmpty(this.ErrorMessage))
                {
                    _hasErrors = true;
                }
                return _hasErrors;
            }
            set
            {
                _hasErrors = value;
            }
        }

With that, in the view, you just check if your Model.hasError, otherwise you can use the Model.Value.

T could be string, custom object, or collection list of whatever you want... so you could use it on the whole project

edited May 4, 2015 at 8:31

answered May 4, 2015 at 8:18

clement

4,27610 gold badges67 silver badges138 bronze badges

1 Comment

CodeCaster Over a year ago

"The cleanest solution" - no, you're just rebuilding the ModelState. Explain why this is a good solution and what it adds over existing mechanisms for error handling and display.

Collectives™ on Stack Overflow

.NET MVC Return to View from controller without model

3 Answers 3

3 Comments

10 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

10 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related