php to javascript loop

Question

Question

I'm trying to place markers on a map by retrieving them via php, looping them into javascript arrays then looping the arrys to add the markers.

db query

require_once("func/connect.php");
$query = "SELECT * FROM site_locations;";
$stmt = $db->prepare($query);
$stmt->execute();

creating creating js arrays

<script type="text/javascript">
    var lat = new Array();
    var lon = new Array();
    var site = new Array();

    <?php 
    while($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
        $lat = json_encode($row['latitude']);
        $long = json_encode($row['longitude']);
        $site = json_encode($row['site_name']);

        ?>
        lat.push(<?php  echo '\'';
                        echo $lat;
                        echo '\''; ?>);


        lon.push(<?php  echo '\'';
                        echo $lon;
                        echo '\''; ?>);

        site.push(<?php  echo '\'';
                        echo $site;
                        echo '\''; ?>);

        <?php
    }
    ?>
</script>

Finally adding looping the js arrays to add markers

    markers: [
        for (i = 0; i < lat.length; i++) {
            {
                latLng: [lat[i], lon[i]],
                name: site[i]
            },
        }
    ]

As it currently stands, this does not work. The PHP side of things works.

Also tried

    markers: [
        for (var i = 0; i < lat.length; i++) {
            {
                latLng: [lat(i), lon(i)],
                name: site(i)
            },
        }
    ]

Looks like an issue with the illegal string literal termination — Arun P Johny
– Arun P Johny, Commented May 5, 2015 at 10:31
not sure about the PHP syntax lat.push(<?php echo '\'$lat\''; ?>); — Arun P Johny
– Arun P Johny, Commented May 5, 2015 at 10:32
You cannot have a for loop statement inside a literal array statement — Patrick Evans
– Patrick Evans, Commented May 5, 2015 at 10:36
@PatrickEvans the for loops is outside of the while loop, is that what you mean? — Danny123
– Danny123, Commented May 5, 2015 at 10:52
No I mean, markers: [ for (var .... you would get an error trying to do this. — Patrick Evans
– Patrick Evans, Commented May 5, 2015 at 16:30

jmgross · Accepted Answer · 2015-05-05 11:01:09Z

3

You could make the work on the PHP side :

<?php 
    $points = array();
    while($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
        $point = new stdClass();
        $coords = array();
        $coords[] = floatval($row['latitude']);
        $coords[] = floatval($row['longitude']);
        $point->latLng = $coords;
        $point->name = $row['site_name'];

        array_push($points, $point);
    }
?>

<script>
var points = <?php echo json_encode($points); ?>;
</script>

And then init your maps with the javascript variable :

markers: points

edited May 5, 2015 at 11:01

answered May 5, 2015 at 10:38

jmgross

2,3461 gold badge22 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Danny123 Over a year ago

I'm having a play around to try and get it to work, seems like a few errors kick up. I'll sort it and check to see if we have any luck

Danny123 Over a year ago

Just changed the var points to an echo, $points to an array push and it works perfectly. Thank you

Marek · Accepted Answer · 2015-05-05 10:34:41Z

1

You already json_encode() the values, hence the single quotes in js are breaking it. Use:

site.push(<?php  echo $site; ?>);

answered May 5, 2015 at 10:34

Marek

7,4431 gold badge24 silver badges34 bronze badges

1 Comment

Danny123 Over a year ago

ah yes, this is true thank you for pointing that out. However, It apparently isn't the only school-boy-error in my code.

Collectives™ on Stack Overflow

php to javascript loop

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related