PHP json foreach returning only last record

Question

Helo, i am having a problem with my json, i am having a foreach in a foreach in a for... dont ask why

My problem is that the foreach foreach( $result2 as $rowx ) only returns the last record. the query is ok is working fine it returns 2 fields from database , but only the last is echo'ed.

Any help please.

 if(!$location){
    echo '{"locations":[';
    $query = $db->prepare("SELECT * FROM locations"); 
    $query->execute();
    $result = $query -> fetchAll();
    $num_rows = count($result);
           for ($x = 1; $x < $num_rows; $x++) {
    foreach( $result as $row ) { 
    $qer = "SELECT DISTINCT t.id_temp,f.id_fridge,l.id_location,t.id_sensor,f.denumire AS 'fridge_name',l.name AS 'location_name',l.address AS 'location_address',t.date,t.time,t.temp FROM fridges AS f,locations AS l,temperature AS t WHERE f.fk_location=l.id_location AND f.fk_id_sensor=t.id_sensor AND l.id_location='1' AND t.date='07/05/2015' ORDER BY t.id_temp DESC LIMIT 0,2";

    $query2 = $db->prepare($qer); 
    $query2->execute();
    $result2 = $query2 -> fetchAll();



    echo '{"location_name":"'.$row[1].'","nr_fridges":'.$row[2].',"fridge":';
    foreach( $result2 as $rowx ) { 

    }
    echo '{
    '.$rowx['fridge_name'].'

    }'; 

    echo '}';

    }
        echo "]}";
    exit; 
    }
    }

Check at json_encode function, it will make debug really easier because in this way, it is really hardly readable — xNeyte
– xNeyte, Commented May 11, 2015 at 7:26

pavel · Accepted Answer · 2015-05-11 07:26:47Z

2

You have echoes outside the loop.

foreach( $result2 as $rowx ) { 
    echo '{
        '.$rowx['fridge_name'].'
    }'; 

    echo '}';
}

echo "]}";

answered May 11, 2015 at 7:26

pavel

27.3k11 gold badges47 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jeroen · Accepted Answer · 2015-05-11 07:27:30Z

0

Your problem is probably caused by the fact that you are using $rowx['fridge_name'] after the loop instead of inside it:

foreach( $result2 as $rowx ) { 

}
echo '{
'.$rowx['fridge_name'].'

}';

should be:

foreach( $result2 as $rowx ) { 
  echo '{
  '.$rowx['fridge_name'].'
  }'; 
}

Also note that now you are not building valid json as an object would need a key - value pair where string values are quoted in double quotes ".

However, you should not build json manually anyway, instead you should build an array of the form you need and at the very end you do:

echo json_encode($your_array);

answered May 11, 2015 at 7:27

jeroen

91.8k22 gold badges117 silver badges132 bronze badges

Comments

ANjaNA · Accepted Answer · 2015-05-11 07:28:52Z

0

foreach( $result2 as $rowx ) { //foreach begin

    } //foreach end

your echo is outside the foreach loop.

Try this,

foreach( $result2 as $rowx ) { 
    echo '{
    '.$rowx['fridge_name'].'
    }';
}

answered May 11, 2015 at 7:28

ANjaNA

1,4322 gold badges16 silver badges31 bronze badges

Collectives™ on Stack Overflow

PHP json foreach returning only last record

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related