JavaScript splitting a string error

Question

I'm trying to split this string

"http://localhost/webproject/products.html?product=Apple%20iPhone%206%20With%20FaceTime%20class="

to this

"Apple iphone 6 with Facetime"

but my code only splits it to

"Apple iphone 6 with Facetime class"

and when I'm trying to remove the class word and alert the string, it appears as empty. When I alert split5 it appears as NaN

var url = window.location.href;
var split = url.split('=');
var split2 = split[1];
var split3 = split2.replace(/20/g,"");
var split4 = split3.replace(/%/g, " ");
var split5 = split4.count-5;
var split6 = split4.slice(0, split5);
alert(split6);

Save yourself some time: var split2 = decodeURI(split[1]); — Brian Glaz
– Brian Glaz, Commented May 18, 2015 at 18:58
Dammit I forgot thank you. I'm used to the Array List in c#. — Karim
– Karim, Commented May 18, 2015 at 18:59
If product and class are meant to be separate arguments, there should be a & between them that you can .split() on first. — Jonathan Lonowski
– Jonathan Lonowski, Commented May 18, 2015 at 19:00

iSkore · Accepted Answer · 2016-03-09 22:44:38Z

1

@Karim, what's going on is you're using replace and then counting the -5 over the location of those characters. That's why it is returning NaN.

Here is what you want:

var url = 'http://localhost/webproject/products.html?product=Apple%20iPhone%206%20With%20FaceTime%20class=';
var split = url.split('=');
var split2 = split[1];
var split3 = split2.split('%20');
alert(split3.join(' '));

edited Mar 9, 2016 at 22:44

answered May 18, 2015 at 19:11

iSkore

7,5793 gold badges36 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dilip Kumar · Accepted Answer · 2015-05-18 19:01:59Z

0

You can done better way using decodeURI() method. Instead of count you have to use length.

string don't have count property that is why you are getting `NaN1.

var url = window.location.href;
var split = url.split('=');
var split2 = decodeURI(split[1]);
var split5 = split2.length-5;
var split6 = split2.substring(0, split5);
alert(split6);

answered May 18, 2015 at 19:01

Dilip Kumar

2,5442 gold badges20 silver badges33 bronze badges

Comments

Ajm Iam · Accepted Answer · 2015-05-18 19:03:07Z

0

Also, as a shortcut, you can set the second argument of the string.slice method to a negative number to remove that many characters from the end of the string, eg -5 to slice off the last 5 characters.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/slice

answered May 18, 2015 at 19:03

Ajm Iam

1612 silver badges11 bronze badges

Comments

Charlesthk · Accepted Answer · 2015-05-18 19:26:27Z

0

You can split your string by '%20', remove the last value using pop() and then join the result:

var url = "http://localhost/webproject/products.html?product=Apple%20iPhone%206%20With%20FaceTime%20class="

var split1 = url.split('=')[1]
var split2 = split1.split('%20')
split2.pop()
alert(split2.join(' '))

More info on Array.prototype.pop()

edited May 18, 2015 at 19:26

answered May 18, 2015 at 18:59

Charlesthk

9,7545 gold badges46 silver badges49 bronze badges

Collectives™ on Stack Overflow

JavaScript splitting a string error

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related