Powershell Error Validation

Question

Function Button_Click()
{
       Param([Parameter(Mandatory=$True)]

            $telephone,
            $calledtoSee,
            $wantstoSeeyou,
            $pleaseCall,
            $willcallAgain,
            $returningYourCall,
            $ToSelection,
            $from,
            $telephoneNumber,
            $message) 


    [boolean]$okayContinue=$true
    [string]$radioSelectedText
    [string]$comboBoxSectionText
    [string]$persontoEmail
    $callType
    $messageCount

     $comboBoxSectionText = $ToSelection.GetItemText($ToSelection.SelectedItem)


     if($okayContinue){

                    if($comboBoxSectionText -eq "Please Select Contact"){
                        [System.Windows.Forms.MessageBox]::Show("Please Select Recipient")
                        $okayContinue=$false

                    }

     }

     if($okayContinue){

                    if([string]::IsNullOrWhiteSpace($from.Text)){
                        [System.Windows.Forms.MessageBox]::Show("Please Enter Who The Message is From")
                        $from.focus()
                        $okayContinue=$false
                    }
    }

    if($okayContinue){

                    if([string]::IsNullOrWhiteSpace($telephoneNumber.Text)){
                        [System.Windows.Forms.MessageBox]::Show("Please Enter Telephone Number")
                        $telephoneNumber.focus()
                        $okayContinue=$false
                   }
     }
     #######################################################################################################################################################

     if($okayContinue){

            if($telephone.Checked){
                    $callType = $telephone.Text
            }
            elseif($calledtoSee.Checked){
                    $callType =  $calledtoSee.Text
            }
            elseif($wantstoSeeyou.Checked){
                    $callType =   $wantstoSeeyou.Text
            }
            elseif($pleaseCall.Checked){
                    $callType= $pleaseCall.Text
            }
            elseif($willcallAgain.Checked){
                    $callType = $willcallAgain.Text
            }
            elseif($returningYourCall.Checked){
                    $callType = $returningYourCall.Text
            }
            else{
                 [System.Windows.Forms.MessageBox]::Show("Please Select Call Type")
                 $okayContinue=$false
            }

    }

    if($okayContinue){

        if([string]::IsNullOrWhiteSpace($message.Text)){

            [System.Windows.Forms.MessageBox]::Show("Please Enter Message")
            $okayContinue=$false
        } 


    }





    if($okayContinue){

            $buildPerson=$comboBoxSectionText.Split(',') 

            $personObject = [pscustomobject]@{

                    FirstName = $buildPerson[0]
                    LastName = $buildPerson[1]
                    Email = $buildPerson[2]
            }

            $messageObject = [pscustomobject]@{

                   Message = $message.Text
                   MessageFor = $personObject
                   From = $from.Text
                   CallType = $callType
                   Telephone = $telephoneNumber.Text
            }
        }

I've got a form with 6 radio buttons, and 2 text boxes, and a combobox. Now, in terms of error validation, I decided to use a boolean value and check to see that the textboxes are properly filled and that a recipient has been selected. After everything has been filled in, then an object is created.

Am I on the right track when it comes to error validation? Could I be handling it better?

It sounds like you are trying to do Data Validation. Also if your code actually does work Code Review might be a better fit for this. — Matt
– Matt, Commented May 26, 2015 at 14:07
@Matt - Thanks. In your opinion, am I on the right track? Could I be handling this better? — user4350786
– user4350786, Commented May 26, 2015 at 14:09

JPBlanc · Accepted Answer · 2015-05-26 15:17:27Z

1

If you want full programmatic control over validation, or need to perform complex validation checks, you should use the validation events built into most Windows Forms controls. Each control that accepts free-form user input has a Validating event that will occur whenever the control requires data validation. In the Validating event-handling method, you can validate user input in several ways. Have a look to Event-Driven Validation. And More explanations here : Extending Windows Forms with a Custom Validation.

edited May 26, 2015 at 15:17

answered May 26, 2015 at 14:13

JPBlanc

73k17 gold badges137 silver badges180 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

user4350786 Over a year ago

The code that I've posted, do you see any logic errors? I'm I on the right track in terms of validation?

JPBlanc Over a year ago

For me the validation code should not be in OnClick event, but in dedicated events like OnValidating, have a look to the articles in my answer.

user4350786 Over a year ago

@JPBlanc- You mean, each control has its own even handler to handle validation? That's what those articles seem to suggest/demonstrate

JPBlanc Over a year ago

Yes, that's the point. You can even show a red '!' with an associated message.

user4350786 Over a year ago

Thanks for the links and help. Much appreciated.

|

Collectives™ on Stack Overflow

Powershell Error Validation

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related