22

I need to avoid being vulnerable to SQL injection in my ASP.NET application. How might I accomplish this?

0

16 Answers 16

30

Even though your question is very generic, a few rules always apply:

  • Use parameterized queries (SqlCommand with SqlParameter) and put user input into parameters.
  • Don't build SQL strings out of unchecked user input.
  • Don't assume you can build a sanitizing routine that can check user input for every kind of malformedness. Edge cases are easily forgotten. Checking numeric input may be simple enough to get you on the safe side, but for string input just use parameters.
  • Check for second-level vulnerabilites - don't build SQL query strings out of SQL table values if these values consist of user input.
  • Use stored procedures to encapsulate database operations.
Sign up to request clarification or add additional context in comments.

6 Comments

All of those, except maybe the last one, are implied by the first one (if all your input is properly escaped, always, by the use of prepared statements (or parameterized queries)), no? Or you think there are subtle differences?
No. But someone who asks these kinds of questions very likely has no firm understanding of the implications. Making them explicit is supporting comprehension. As your experience and abilities to abstract rise, you won't need the explicitness, and you're not likely to ask such questions anymore.
This is a good answer, but I feel that "Use stored procedures to encapsulate database operations" is misleading. Parameterized dynamic SQL is just as safe as parameterized stored procedures. Maybe you should make that more implicit in your answer for clarity's sake.
@Daniel: Parameterizes queries as used with SqlCommand, are to be used if the developer has not much control or expertise in the database technical stuff. Creating stored procedures in the database is not straight forward if you are a plain C# developer and not DBA. Using stored procedures is a good way to do it if the DBA(s) wants to do it in order to encapsulate complexity for the C# developers.
@Vinko: I agree. The answer could be made better by splitting up in 2 sections: First the points 2-4 as answer to what you need to consider, and then points 1 and 5 as possible solutions on how to solve the issues pointed out.
|
18

Use parameters! It really is that simple :-)

Create your queries like this (for MS Sql server with C#):

SqlCommand getPersons = new SqlCommand("SELECT * FROM Table WHERE Name = @Name", conn); 

Here @Name is the parameter where you want to avoid sql injection and conn is an SqlConnection object. Then to add the parameter value you do the following:

getPersons.Parameters.AddWithValue("@Name", theName);

Here theName is a variable that contains the name you are searching for.

Now it should be impossible to do any sql injections on that query.

Since it is this simple there is no reason not to use parameters.

Comments

17

Use Prepared Statements (link to an ASP.NET tutorial that uses prepared statements in the 'To add nodes for products' section). that's all there is to it.

Well, that or use an ORM, like Linq to SQL or NHibernate, they internally use prepared statements.

Comments

16

Never trust user input - Validate all textbox entries using validation controls, regular expressions, code, and so on

Never use dynamic SQL - Use parameterized SQL or stored procedures

Never connect to a database using an admin-level account - Use a limited access account to connect to the database

Don't store secrets in plain text - Encrypt or hash passwords and other sensitive data; you should also encrypt connection strings

Exceptions should divulge minimal information - Don't reveal too much information in error messages; use customErrors to display minimal information in the event of unhandled error; set debug to false

Useful link on MSDN Stop SQL Injection

3 Comments

Good answer, but, I disagree with "Never use dynamic SQL". Dynamic SQL is a very generic term and can be very powerful and there are many cases where it should be used. Your point should just be pass variable data as parameters.
Aye Robin, I agree Dynamic SQL can be very useful and there are some good cases where it should be used, by my points where based solely on the interaction with a user in the outside world, to stop them injecting SQL. For example, a SQL statements constructed by the concatenation of SQL with user-entered values.
hmm I just got -1 vote as well as a number of posts below me bumping us all down? (all by the same user maybe??)
5

SQL injection occurs because the query to the database is being constructed in real time, for example:

SELECT * From Table1 WHERE " + UserInput

UserInput may be malicious and contain other statements that you do not intend.

To avoid it, you need to avoid concatenating your query together.

You can accomplish this by using parametrized queries - check out the DBCommand object for your particular DB flavor.

Comments

4

Use parametrized queries and/or stored procedures and parse your parameters via SQL parameters. Never generate SQL code by concatenating strings. Also do some reading about SQL injection and about writing secure code, because preventing SQL injection is only a small part of security. There is many more (like XSS - Cross Site Scripting). If a hacker wants to compromise your site/application he will look for more then only SQL injection.

Comments

4

Scott Guthrie posted a decent little article about this a while back. In it, he offers 5 suggestions for protecting yourself:

  1. Don't construct dynamic SQL Statements without using a type-safe parameter encoding mechanism. [...]

  2. Always conduct a security review of your application before ever put it in production, and establish a formal security process to review all code anytime you make updates. [...]

  3. Never store sensitive data in clear-text within a database. [...]

  4. Ensure you write automation unit tests that specifically verify your data access layer and application against SQL Injection attacks. [...]

  5. Lock down your database to only grant the web application accessing it the minimal set of permissions that it needs to function. [...]

He does a decent job of explaining why these are important, and links to several other resources as well...

1 Comment

Important alright, but only the first bullet addresses the OP's question.
3

NEVER trust user input, always validate it, and use sql parameters. Should be enough basis to prevent SQL injection.

Comments

2

Hopefully, this will help:

http://www.codersbarn.com/post/2008/11/01/ASPNET-Data-Input-Validation.aspx

The short answer is to use parameterized queries.

Anthony :-) www.codersbarn.com

Comments

2

Always use only parameterized queries.

Comments

1

As others have said, don't concatenate user input to create dynamic sql statements; always use parameterized SQL when using dynamic SQL. However I will point out that this rule also applies when creating dynamic sql inside of a stored proc. This fact is something people often overlook. They think they are safe because they are "using stored procedures."

Comments

0

The book, "Building Secure ASP.NET Applications" guideline has a section on this topic.

Comments

0

Use XSS Secured UrlEncode using Microsoft.Security.Application.AntiXss.UrlEncode and SQL injection will not work. Or You can use ASP.NET – JSON – Serialization and Deserialization

Also test your application with SiteDigger from Macfee Fre Tool.

Few More are from here

.NET Security Toolkit v1.0 .NETMon v1.0 Validator.NET v1.0

Comments

0

Everyone says "Use parameters". We'd have to say it less if it wasn't so perversely difficult.

Use QueryFirst. The temptation to concatenate is removed, and the right way becomes the easiest way. You create a parameter just by typing @myParam in your SQL, the tool does the rest.

disclaimer: I wrote QueryFirst

Comments

-3

Understand what exactly SQL Injection is and then never write anything that is vulnerable to it.

Comments

-4

Try to use Stored Procedures, and validate the input on your data. Do not use any direct SQL like INSERT INTO ...

1 Comment

Stored Procedures have nothing to do with it, you can execute a SP in an insecure way by not parameterizing the call.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.