Powershell for loop

Question

I have to print all the directories and all the files. But If I find a directory I have to "enter to the directory" and print the files stored in that directory. It only have two levels, the first level is full fo directorys and the second level there are files.

I've tried this but, it doesn't enter to the directory, it all the directorys two times

$correcte = $args.Count
if ($correcte -lt 1){
    forEach ($item in (Get-ChildItem)){ //first level of directories
       if($item.PSIsContainer){
          forEach ($item in (Get-ChildItem)){               
             write-host $item //this should print the file inside the directory
          }
        }
    }
}
else{
    write-host "You don't have to pass any parameter"
}

arco444 · Accepted Answer · 2015-06-01 14:13:57Z

3

You need to re-use the $item variable in the second loop once you've determined it's a directory.

As Enrico points out, also best to use a different variable name:

$correcte = $args.Count
if ($correcte -lt 1){
    forEach ($item in (Get-ChildItem)){ //first level of directories
       if($item.PSIsContainer){
          forEach ($subitem in (Get-ChildItem $item)){               
             write-host $subitem.FullPath //this should print the file inside the directory
          }
        }
    }
}
else{
    write-host "You don't have to pass any parameter"
}

Depending on your powershell version, you might be able to simplify this by just getting the directories in the first place:

Get-ChildItem -Directory | % { gci $_ }

answered Jun 1, 2015 at 14:13

arco444

23k12 gold badges66 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Enrico · Accepted Answer · 2015-06-01 14:10:25Z

0

It looks like Get-ChildItem is executed in the same folder both times. You need to "move" into the target directory before calling Get-ChildItem again.

As a side note, it's not a great idea to reuse the variable name item again in your inner loop. It's confusing.

answered Jun 1, 2015 at 14:10

Enrico

10.8k8 gold badges46 silver badges58 bronze badges

Comments

Paul · Accepted Answer · 2015-06-01 14:26:12Z

0

Get-Childitem has a -recurse parameter that does exactly that. If you only want to print out the item like it was generated by gci the following will suffice:

Get-Childitem -recurse

edited Jun 1, 2015 at 14:26

answered Jun 1, 2015 at 14:13

Paul

5,9412 gold badges27 silver badges42 bronze badges

Collectives™ on Stack Overflow

Powershell for loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related