Flatten nested arrays using recursion in JavaScript

Question

I'm trying to flatten nested arrays while preserving the order, e.g. [[1, 2], 3, [4, [[5]]]] should be converted to [1, 2, 3, 4, 5].

I'm trying to use recursion in order to do so, but the code below does not work and I don't understand why. I know there are other methods to do it, but I'd like to know what's wrong with this.

function flatten (arr) {
  var newArr = [];
  for (var i = 0; i < arr.length; i++) {
    if (Array.isArray(arr[i])) {
      flatten(arr);
    } else {
      newArr.push(arr[i]);
    }
  }
  return newArr;
}

flatten([[1, 2], 3, [4, [[5]]]]);

Thanks

Sorry, it's one of the freecodecamp challenges and I changed the name for something more descriptive, but I forgot that one. That's not the issue though. — user1576121
– user1576121, Commented Jun 1, 2015 at 20:18
See my recursive version of array flattening in this stackoverflow page — Sandro Rosa
– Sandro Rosa, Commented Apr 18, 2021 at 8:20

OrenD · Accepted Answer · 2015-06-01 20:20:40Z

14

When calling flatten recursively, you need to pass arr[i] to it and then concat the result with newArr. So replace this line:

flatten(arr);

with:

newArr = newArr.concat(flatten(arr[i]));

answered Jun 1, 2015 at 20:20

OrenD

1,74113 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Maurice Makaay · Accepted Answer · 2017-06-13 16:09:45Z

5

Here's a common pattern that I regularly use for flattening nested arrays, and which I find a bit more clean due to its functional programming nature:

var flatten = (arrayOfArrays) =>
    arrayOfArrays.reduce((flattened, item) =>
        flattened.concat(Array.isArray(item) ? flatten(item) : [item]), []);

Or for those who like a shorter, less readable version for code golf or so:

var flatten=a=>a.reduce((f,i)=>f.concat(Array.isArray(i)?flatten(i):[i]),[]);

answered Jun 13, 2017 at 16:09

Maurice Makaay

531 silver badge2 bronze badges

1 Comment

tanguy_k Over a year ago

Line Array.isArray(item) ? flatten(item) : [item]: [item] should be item => Array.isArray(item) ? flatten(item) : item

sjager · Accepted Answer · 2015-06-01 20:21:32Z

1

Here is some working code

function flatten (arr) {
  var newArr = [];
  for (var i = 0; i < arr.length; i++) {
    if (Array.isArray(arr[i])) {
      var temp = flatten(arr[i]);
      temp.forEach(function(value){ newArr.push(value); })
    } else {
      newArr.push(arr[i]);
    }
  }
  return newArr;
}

answered Jun 1, 2015 at 20:21

sjager

4162 silver badges5 bronze badges

Comments

edmarisov · Accepted Answer · 2015-06-01 20:24:08Z

1

Havent tested it, bit this part

if (Array.isArray(arr[i])) {
      flatten(arr);
    } else {

Seems to be intended as

if (Array.isArray(arr[i])) {
  flatten(arr[i]);
} else {

answered Jun 1, 2015 at 20:24

edmarisov

1585 bronze badges

3 Comments

Bergi Over a year ago

Where's the difference?

edmarisov Over a year ago

@Bergi difference is in passing a [i] instead of a. But one thing missing here -as OrenD mentioned is concatenation of results

Bergi Over a year ago

Ah, you should've stated that explicitly in your answer. I only spotted the changed indentation.

Jay Agrawal · Accepted Answer · 2021-04-16 20:24:48Z

0

This solution is without using any Array methods

//1 >> loop inside parent
//2 >> if the element is not an array then push it in array that has to be returned or else loop inside it

const arr = [[0, 1], [2, 3], [4, 5, [6, 7, [8, [9, 10]]]]]

function toFlatArray(arr) {
  let flatArray = [];
  function rec(a) {
    if (!Array.isArray(a)) {
      flatArray.push(a);
    } else {
      for (let i = 0; i < a.length; i++) {
        rec(a[i]);
      }
    }
  }
  rec(arr);
  return flatArray;
}



const flatArray = toFlatArray(arr);

console.log("flatArray", flatArray);

answered Apr 16, 2021 at 20:24

Jay Agrawal

1

1 Comment

B001ᛦ Over a year ago

..This solution is without using any Array methods... Please explain what is the benefit of your answer compared to others

ByteTheBits · Accepted Answer · 2021-06-27 18:39:08Z

0

Easy to understand solution:

var flatten = function(array) {
    let flatArray = [];
  
  array.forEach(element => {
    if (Array.isArray(element)) {
      let inner = flatten(element);
      flatArray.push(...inner)
    } else {
        flatArray.push(element);
    }
  })
  
  return flatArray;
};

answered Jun 27, 2021 at 18:39

ByteTheBits

3291 gold badge6 silver badges15 bronze badges

Comments

VKumar · Accepted Answer · 2021-08-19 17:20:24Z

0

Recursive Solution!


let newArray = [];
function arrayFlat(array){
    for(let i = 0; i< array.length; i++){
        if(!array[i].length) { newArray.push(array[i])};
        arrayFlat(array[i]);
    }
    console.log(newArray);
}

arrayFlat(arrayData);

// Array to be flattened.
arrayData = [1,2,[3,4],[[5,6],7]];

answered Aug 19, 2021 at 17:20

VKumar

11 bronze badge

Collectives™ on Stack Overflow

Flatten nested arrays using recursion in JavaScript

7 Answers 7

Comments

1 Comment

Comments

3 Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

1 Comment

Comments

3 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related