How can I recursively convert a nested array to a flat array?

Question

I'm trying to get this nested array to a flat array. While using this way to solve it seems every time I callback arrayFlattener(element) the newArr become a empty array. Can someone help me with this? Thank you.

const arrayFlattener = (arr) => {
    let newArr = [];
    
    for (let i = 0; i < arr.length; i++) {
        let element = arr[i];
        if (Array.isArray(element)){
            newArr.push(arrayFlattener(element));
            
        } else {
            newArr.push(element);
        }
    }
    return newArr;
}
console.log(arrayFlattener(['I', 'am', 'working', ['on', 'another', 'level']]));

It would be helpful if you tagged this question with the language you're working in. (I'd do it for you, but I don't recognize the syntax.) — user1118321
– user1118321, Commented Mar 8, 2019 at 4:23
Are you looking for general recursion, tail recursion, or iterative recursion? — Jodast
– Jodast, Commented Mar 8, 2019 at 5:10

Aziz.G · Accepted Answer · 2019-03-08 16:01:57Z

2

flat do the job with the depth param level specifying how deep a nested array structure should be flattened.

Example

const arr = ['I', 'am', 'working', ['on', 'another', 'level'], 'now', ["now", ["hello", "you you"]]]

console.log(arr.flat(2))

edited Mar 8, 2019 at 16:01

answered Mar 8, 2019 at 15:45

Aziz.G

3,7813 gold badges20 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

גלעד ברקן · Accepted Answer · 2019-03-08 16:12:32Z

2

Your code and theory are fine. You just chose the wrong method. Use concat instead of push (to extend the result rather than insert into it):

const arrayFlattener = (arr) => {
    let newArr = [];
    
    for (let i = 0; i < arr.length; i++) {
        let element = arr[i];
        if (Array.isArray(element)){
            newArr = newArr.concat(arrayFlattener(element));
            
        } else {
            newArr.push(element);
        }
    }
    return newArr;
}
console.log(arrayFlattener(['I', 'am', 'working', ['on', 'another', 'level']]));

edited Mar 8, 2019 at 16:12

answered Mar 8, 2019 at 15:40

גלעד ברקן

24k3 gold badges29 silver badges64 bronze badges

Comments

Nadir Laskar · Accepted Answer · 2019-03-17 17:59:38Z

2

You can use flatMap

let newArr = ['I', 'am', 'working', ['on', 'another', 'level']].flatMap(el=>el);

console.log(newArr);

or use flat

var arr1 = [1, 2, [3, 4]];
arr1.flat(); 
// [1, 2, 3, 4]

var arr2 = [1, 2, [3, 4, [5, 6]]];
arr2.flat();
// [1, 2, 3, 4, [5, 6]]

var arr3 = [1, 2, [3, 4, [5, 6]]];
arr3.flat(2); // depth argument to flatten the array
// [1, 2, 3, 4, 5, 6]

edited Mar 17, 2019 at 17:59

answered Mar 8, 2019 at 4:35

Nadir Laskar

4,1702 gold badges19 silver badges33 bronze badges

1 Comment

Nadir Laskar Over a year ago

I agree, if you need to implement recursion you can do how @Andreas answered but also I believe browser implementation will be faster than implementing a recursion.

Andreas · Accepted Answer · 2019-03-08 04:23:55Z

1

Currently, your function did not flatten the array, but simply parse through every individual element of the array. It still returns the same array structure.

To flatten the array, you should pass the resulting array as well, so that the individual element can be pushed straight into the resulting array instead of making another array and push it to the resulting array (which produce the same initial array structure)

let newArr = [];
const arrayFlattener = (arr, result) => {
    for (let i = 0; i < arr.length; i++) {
        let element = arr[i];
        if (Array.isArray(element)){
            result = arrayFlattener(element, result);
            
        } else {
            result.push(element);
        }
    }
    return result
}
console.log(arrayFlattener(['I', 'am', 'working', ['on', 'another', 'level'], 'now'], newArr));

answered Mar 8, 2019 at 4:23

Andreas

2,52110 gold badges24 silver badges25 bronze badges

2 Comments

Nadir Laskar Over a year ago

Why not use flattenMap?

גלעד ברקן Over a year ago

This seems a little weird. I think it's more common to enter just an input and expect a result rather than entering both an input and a pointer to the result, unless the latter is absolutely necessary.

Chris Vouga · Accepted Answer · 2019-07-02 03:42:27Z

1

Here's three solutions

You can use .flatMap and recursion or

const flatten = (xs) =>
  Array.isArray(xs) ? xs.flatMap(flatten) : [xs]

const array = ['I', 'am', 'working', ['on', 'another', ['level']]]

console.log(flatten(array))

you can use .reduce and recursion

const flatten = (xs) =>
  xs.reduce(
    (y, x) => y.concat(Array.isArray(x) ? flatten(x) : [x]),
    [])

const array = ['I', 'am', 'working', ['on', 'another', ['level']]]

console.log(flatten(array))

or even better just use .flat

const flatten = (xs) =>
  xs.flat(Infinity)

const array = ['I', 'am', 'working', ['on', 'another', ['level']]]

console.log(flatten(array))

answered Jul 2, 2019 at 3:42

Chris Vouga

5546 silver badges8 bronze badges

Collectives™ on Stack Overflow

How can I recursively convert a nested array to a flat array?

5 Answers 5

Comments

Comments

1 Comment

2 Comments

Here's three solutions

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

1 Comment

2 Comments

Here's three solutions

Comments

Your Answer

Sign up or log in

Post as a guest

Related