If Statement not working in my jquery Function?

Question

I have a simple calculator with 2 tabs that i am building. One of those tabs are disabled with a class called .not-active. I want to remove that class when the value of #amount is > 195. However even though the if statement is in place it removes the class upon change of value, Even when value is < 195.

Here is my jquery function:

$(function() {
$( "#slider-range-min1" ).slider({
  range: "min",
  value: 40,
  min: 5,
  max: 700,
  step: 5,
  slide: function( event, ui ) {
    $( "#amount" ).val( ui.value );
    if ($('#amount').val() > "195") {
        $('#l2').removeClass('not-active');
    };

  }
});
$( "#amount" ).val( $( "#slider-range-min1" ).slider( "value" ));

});

AmmarCSE · Accepted Answer · 2015-06-03 12:08:10Z

1

Use parseInt and integers

$(function() {
$( "#slider-range-min1" ).slider({
  range: "min",
  value: 40,
  min: 5,
  max: 700,
  step: 5,
  slide: function( event, ui ) {
    $( "#amount" ).val( ui.value );
    if (parseInt($('#amount').val()) > 195) {
        $('#l2').removeClass('not-active');
    };

  }
});
$( "#amount" ).val( $( "#slider-range-min1" ).slider( "value" ));

});

answered Jun 3, 2015 at 12:08

AmmarCSE

30.7k6 gold badges48 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rory McCrossan · Accepted Answer · 2015-06-03 12:07:49Z

0

To compare properly, you need to ensure that both values are integers. You can use parseInt() to convert the #amount value. Try this:

if (parseInt($('#amount').val(), 10) > 195) {
    $('#l2').removeClass('not-active');
};

answered Jun 3, 2015 at 12:07

Rory McCrossan

338k41 gold badges322 silver badges353 bronze badges

Comments

Praveen Kumar Purushothaman · Accepted Answer · 2015-06-03 12:07:56Z

0

You cannot compare int with string. Change it to:

if (parseInt($('#amount').val()) > 195) {

You have to remove quotes and use parseInt().

answered Jun 3, 2015 at 12:07

Praveen Kumar Purushothaman

167k27 gold badges215 silver badges261 bronze badges

Comments

Sudharsan S · Accepted Answer · 2015-06-03 12:07:59Z

0

Use parseInt(). Actually the value you get from the input field type is string so you need convert to integer. You couldn't check string type with > operator.

if (parseInt($('#amount').val(), 10) > 195) {
        $('#l2').removeClass('not-active');
    };

answered Jun 3, 2015 at 12:07

Sudharsan S

15.4k4 gold badges34 silver badges51 bronze badges

Comments

iCollect.it Ltd · Accepted Answer · 2015-06-05 09:41:31Z

0

The problem, as already pointed out by others, is you are comparing the collation order of strings instead of the values of two numbers.

e.g.

"2" > "123" == true!

You need to convert the string to a number first and compare against another number.

If the numbers are not astronomical in range (i.e. not outside the range of an standard integer... which is pretty huge), you can use ~~ to convert a string to an integer. As well as shorter, it is also faster than parseInt:

e.g.

if (~~$('#amount').val() > 195){

answered Jun 5, 2015 at 9:41

iCollect.it Ltd

93.9k26 gold badges189 silver badges210 bronze badges

1 Comment

iCollect.it Ltd Over a year ago

Perhaps JqueryKing would care to explain why he down-voted this correct and useful alternative answer? If he is such an expert he should have known this trick already :)

Collectives™ on Stack Overflow

If Statement not working in my jquery Function?

5 Answers 5

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related