returning error in AngularJS service

Question

I have this authentication service, that checks if the user has a Session stored. and if it get's the info from the api by returning the $http.post():

authService.getUser = function () {
    if (!SessionService.get('Auth')) return null;

    $userId = SessionService.get('User');
    SessionService.set('Auth', false); // reset to false

    if ($userId == null) return null;


    return $http.get('/api/users/' + $userId)
        .success(function (res) {
            SessionService.set('Auth', true);
            return res;
        })
        .error(function () {
            return null;
        });
}

and this is called like following:

AuthenticationService.getUser()
    .success(function (res) {
        $scope.user = res;
        console.log(res);
    })
    .error(function () {
        Materialize.toast('You are not logged in!');
    });

but this fails ofcourse when it doesn't have a session stored, because I return null.

So how would you change the service that the return null triggers the error()

JB Nizet · Accepted Answer · 2015-06-03 16:04:20Z

4

Simply return a rejected promise:

return $q.reject();

Note that your .error(...)is completely useless.

Also note that since you won't return an HTTP promise, but a regular $q promise, the caller shouldn't use .success() and .error(). It should call .then() and .catch().

edited Jun 3, 2015 at 16:04

answered Jun 3, 2015 at 15:57

JB Nizet

694k94 gold badges1.3k silver badges1.3k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Kiwi Over a year ago

yea the error is useless, because I'm still figuring out how to return the rejection so the error is triggerd :) (looking into the $q.reject(); thingy)

JB Nizet Over a year ago

Just remove the .error(). Your service returns the http promise, which will be rejected if the server returns a 4xx or 5xx response, causing the toast to appear.

Kiwi Over a year ago

ow the error in the $http, yea that one is useless :p but i get a $q is not defined

Okazari Over a year ago

@Kiwi inject the $q service into your controller

Collectives™ on Stack Overflow

returning error in AngularJS service

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related