Populating a listview with a DataReader vb.net

Question

I have to make some modification to an application that have perfomance issues. I ran the profiler and one of the problem is that one:

A sql query is made and stored in a DataReader. The query returns about 2000 rows.

then a while loop start

Dim monSQL as IDataReader 
monSQL = a SQL Query

Do While monSQL.Read
  strArray(0) = 
  strArray(1) = 
  strArray(2) = 
  strArray(3) = monSQL("Something").ToString
  strArray(4) = monSQL("Something").ToString
  strArray(5) = monSQL("Something").ToString

  If Not IsDBNull(monSQL("Something")) Then
    strArray(6) = (monSQL("Something"))
    strArray(7) = monSQL("Something")).ToString
    strArray(8) = monSQL("Something").ToString
    strArray(9) = monSQL("Something").ToString
    strArray(10) = monSQL("Something").ToString
  End If

  objListItem = New ListViewItem(strArray)
  objListItem.Tag = lngNoLot
  ListView.Items.Add(objListItem)
Loop

In the while loop, the data are insert in the listview

It takes quite some time to go throught the loop (about 10 sec)

What are my option to make things go faster?

If you fill a DataTable you can use that as the Datasource for a DataGridview and save lots of time and code — Ňɏssa Pøngjǣrdenlarp
– Ňɏssa Pøngjǣrdenlarp, Commented Jun 4, 2015 at 17:10
Would i still be able to have a check box at the beginning of each row to select a certain row? — Maxime Paré
– Maxime Paré, Commented Jun 4, 2015 at 17:23
The problem is not in inserting the item. Even if I comment everything in the while loop, i.e not adding anything to the list, it takes the same amount of time. — Maxime Paré
– Maxime Paré, Commented Jun 4, 2015 at 17:30
A ListView is sub-optimal for viewing DB data - you are actually making string copies of the data -and lots of subitems - to add to the LV. — Ňɏssa Pøngjǣrdenlarp
– Ňɏssa Pøngjǣrdenlarp, Commented Jun 4, 2015 at 17:35

LarsTech · Accepted Answer · 2015-06-04 16:38:22Z

1

Try suspending any drawing during the loop updates:

listView1.BeginUpdate()
// your loop
listView1.EndUpdate()

answered Jun 4, 2015 at 16:38

LarsTech

81.9k14 gold badges161 silver badges237 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Populating a listview with a DataReader vb.net

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related